Dan-nl has uploaded a new change for review.
https://gerrit.wikimedia.org/r/127211
Change subject: fix MediawikiTemplate::getTitle() method
......................................................................
fix MediawikiTemplate::getTitle() method
* set $file_extension_length to an initial value of 0
* modified the title max length test so that it actually tests the
working title’s strlen()
Bug: 64086
Change-Id: Ic964f214ce80d707c9d76140f8f9749aaf1b1d72
---
M includes/Models/MediawikiTemplate.php
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GWToolset
refs/changes/11/127211/1
diff --git a/includes/Models/MediawikiTemplate.php
b/includes/Models/MediawikiTemplate.php
index 1a13a0b..c6f160d 100644
--- a/includes/Models/MediawikiTemplate.php
+++ b/includes/Models/MediawikiTemplate.php
@@ -367,6 +367,7 @@
*/
public function getTitle( array &$options ) {
$result = null;
+ $file_extension_length = 0;
if ( empty(
$this->mediawiki_template_array['gwtoolset-title-identifier'] ) ) {
throw new GWTException(
'gwtoolset-mapping-no-title-identifier' );
@@ -405,7 +406,7 @@
$result .=
$this->mediawiki_template_array['gwtoolset-title-identifier'];
$result .= '.' . $options['evaluated-media-file-extension'];
- if ( $result > Config::$title_max_length ) {
+ if ( strlen( $result ) > Config::$title_max_length ) {
$result = substr(
$this->mediawiki_template_array['gwtoolset-title-identifier'],
0,
--
To view, visit https://gerrit.wikimedia.org/r/127211
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic964f214ce80d707c9d76140f8f9749aaf1b1d72
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GWToolset
Gerrit-Branch: master
Gerrit-Owner: Dan-nl <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
