Divec has uploaded a new change for review.
https://gerrit.wikimedia.org/r/127598
Change subject: Further segmentation tests
......................................................................
Further segmentation tests
Rudimentary tests for the following cases:
* Period inside quotes
* Sentence boundaries not nestable with inline tags
Change-Id: I0713c463d3502b563733f3ba7c9c7f80fb637b40
---
M tests/segmentation/SegmentationTests.json
A tests/segmentation/data/result-16.html
A tests/segmentation/data/result-17.html
A tests/segmentation/data/test-16.html
A tests/segmentation/data/test-17.html
5 files changed, 15 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/cxserver
refs/changes/98/127598/1
diff --git a/tests/segmentation/SegmentationTests.json
b/tests/segmentation/SegmentationTests.json
index aec60ca..c5be8d2 100644
--- a/tests/segmentation/SegmentationTests.json
+++ b/tests/segmentation/SegmentationTests.json
@@ -81,6 +81,16 @@
"result": "result-15.html"
},
{
+ "desc": "Period inside quotes",
+ "source": "test-16.html",
+ "result": "result-16.html"
+ },
+ {
+ "desc": "Sentence boundaries not nestable with inline
tag",
+ "source": "test-17.html",
+ "result": "result-17.html"
+ },
+ {
"desc": "Paragraph ending with reference and already
having reference in between. The second reference should not be identified as
repeating reference. If identified as repeating reference, 7 letters from last
word will be missing.",
"source":
"test-ends-with-references-missing-letters.html",
"result":
"result-ends-with-references-missing-letters.html"
diff --git a/tests/segmentation/data/result-16.html
b/tests/segmentation/data/result-16.html
new file mode 100644
index 0000000..ce4aeec
--- /dev/null
+++ b/tests/segmentation/data/result-16.html
@@ -0,0 +1,2 @@
+<p id="0"><span class="cx-segment" data-segmentid="1">She said, "Yes."
</span><span class="cx-segment" data-segmentid="2">I smiled.</span>
+</p>
diff --git a/tests/segmentation/data/result-17.html
b/tests/segmentation/data/result-17.html
new file mode 100644
index 0000000..7c09b65
--- /dev/null
+++ b/tests/segmentation/data/result-17.html
@@ -0,0 +1 @@
+<p id="0"><span class="cx-segment" data-segmentid="1">Plutonium is "<i>very
poisonous. </i></span><span class="cx-segment" data-segmentid="2"><i>It can
kill you,</i>" he argues.</span></p>
diff --git a/tests/segmentation/data/test-16.html
b/tests/segmentation/data/test-16.html
new file mode 100644
index 0000000..47ff7e4
--- /dev/null
+++ b/tests/segmentation/data/test-16.html
@@ -0,0 +1 @@
+<p>She said, "Yes." I smiled.</p>
diff --git a/tests/segmentation/data/test-17.html
b/tests/segmentation/data/test-17.html
new file mode 100644
index 0000000..779d074
--- /dev/null
+++ b/tests/segmentation/data/test-17.html
@@ -0,0 +1 @@
+<p>Plutonium is "<i>very poisonous. It can kill you,</i>" he argues.</p>
--
To view, visit https://gerrit.wikimedia.org/r/127598
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0713c463d3502b563733f3ba7c9c7f80fb637b40
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/cxserver
Gerrit-Branch: master
Gerrit-Owner: Divec <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
