Chad has submitted this change and it was merged.
Change subject: Remove "useless override" rule from CodeSniffer
......................................................................
Remove "useless override" rule from CodeSniffer
This rule generates a bunch of false positives that have to
be suppressed. That's annoying. Valid reasons to override a
method that it doesn't allow:
- Changing visibility of constructor in child class
- Changing default parameters to a function
Change-Id: If533caf5a6f9dfd36868ad2ae75380f5999982d8
---
M MediaWiki/ruleset.xml
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Chad: Verified; Looks good to me, approved
Hashar: Looks good to me, but someone else must approve
diff --git a/MediaWiki/ruleset.xml b/MediaWiki/ruleset.xml
index 6de5dbf..94fb91f 100644
--- a/MediaWiki/ruleset.xml
+++ b/MediaWiki/ruleset.xml
@@ -19,7 +19,10 @@
https://pear.php.net/bugs/bug.php?id=19950
<rule ref="Generic.CodeAnalysis.UnusedFunctionParameter" />
-->
- <rule ref="Generic.CodeAnalysis.UselessOverridingMethod" />
+ <!--
+ Useless rule. Test is naïve and flags perfectly legit reasons to
override
+ <rule ref="Generic.CodeAnalysis.UselessOverridingMethod" />
+ -->
<rule ref="Generic.Files.ByteOrderMark" />
<rule ref="Generic.Files.EndFileNewline" />
<rule ref="Generic.Files.LineEndings" />
--
To view, visit https://gerrit.wikimedia.org/r/127863
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If533caf5a6f9dfd36868ad2ae75380f5999982d8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Hashar <has...@free.fr>
Gerrit-Reviewer: Siebrand <siebr...@kitano.nl>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
