jenkins-bot has submitted this change and it was merged.
Change subject: Do not call decodeURI() on non-URIs
......................................................................
Do not call decodeURI() on non-URIs
The title here is not percent-encoded or anything, it's just text.
Calling decodeURI() can cause errors to be thrown if it doesn't happen
to be a valid URI.
Bug: 64236
Change-Id: Iee7c1db0c01cba405f0a2a03b0de58e9edb9a171
---
M resources/ext.popups.core.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yuvipanda: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/ext.popups.core.js b/resources/ext.popups.core.js
index f486d48..6a3de9f 100644
--- a/resources/ext.popups.core.js
+++ b/resources/ext.popups.core.js
@@ -80,7 +80,7 @@
rvprop: 'timestamp',
inprop: 'watched',
indexpageids: true,
- titles: decodeURI( title )
+ titles: title
} );
curRequest.done( function ( re ) {
--
To view, visit https://gerrit.wikimedia.org/r/127907
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee7c1db0c01cba405f0a2a03b0de58e9edb9a171
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Yuvipanda <yuvipa...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
