Krinkle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/129136

Change subject: [WIP] mw.loader: Improve js error logging
......................................................................

[WIP] mw.loader: Improve js error logging

Change-Id: Ie643cf7fba5112b6be0e30410696e1737d549058
---
M resources/src/mediawiki/mediawiki.js
1 file changed, 8 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/36/129136/1

diff --git a/resources/src/mediawiki/mediawiki.js 
b/resources/src/mediawiki/mediawiki.js
index f6154ee..1212d49 100644
--- a/resources/src/mediawiki/mediawiki.js
+++ b/resources/src/mediawiki/mediawiki.js
@@ -786,7 +786,7 @@
                                                        try {
                                                                
styleEl.styleSheet.cssText += cssText; // IE
                                                        } catch ( e ) {
-                                                               log( 
'addEmbeddedCSS fail', e );
+                                                               log( 
'Stylesheet error', e );
                                                        }
                                                } else {
                                                        styleEl.appendChild( 
document.createTextNode( String( cssText ) ) );
@@ -2025,7 +2025,9 @@
                                                                
mw.loader.store.items = data.items;
                                                                return;
                                                        }
-                                               } catch ( e ) {}
+                                               } catch ( e ) {
+                                                       log( 'Storage error', e 
);
+                                               }
 
                                                if ( raw === undefined ) {
                                                        // localStorage failed; 
disable store
@@ -2102,6 +2104,7 @@
                                                                log( 'Detected 
malformed function stringification (bug 57567)' );
                                                        }
                                                } catch ( e ) {
+                                                       log( 'Storage error', e 
);
                                                        return;
                                                }
 
@@ -2172,7 +2175,9 @@
                                                                
localStorage.removeItem( key );
                                                                data = 
JSON.stringify( mw.loader.store );
                                                                
localStorage.setItem( key, data );
-                                                       } catch ( e ) {}
+                                                       } catch ( e ) {
+                                                               log( 'Storage 
error', e );
+                                                       }
                                                }
 
                                                return function () {

-- 
To view, visit https://gerrit.wikimedia.org/r/129136
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie643cf7fba5112b6be0e30410696e1737d549058
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to