Mglaser has uploaded a new change for review.
https://gerrit.wikimedia.org/r/129552
Change subject: SECURITY: escape sortKey in pageInfo
......................................................................
SECURITY: escape sortKey in pageInfo
DEFAULTSORT isn't escaped before being added to the action=info table.
Bug: 63251
Change-Id: I087bfde8cbc69c3507f68ee3cb6e22aba0ffa7db
---
M includes/actions/InfoAction.php
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/52/129552/1
diff --git a/includes/actions/InfoAction.php b/includes/actions/InfoAction.php
index 1e312d7..c0c25b9 100644
--- a/includes/actions/InfoAction.php
+++ b/includes/actions/InfoAction.php
@@ -234,6 +234,7 @@
$sortKey = $pageProperties['defaultsort'];
}
+ $sortKey = htmlspecialchars( $sortKey );
$pageInfo['header-basic'][] = array( $this->msg(
'pageinfo-default-sort' ), $sortKey );
// Page length (in bytes)
--
To view, visit https://gerrit.wikimedia.org/r/129552
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I087bfde8cbc69c3507f68ee3cb6e22aba0ffa7db
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_21
Gerrit-Owner: Mglaser <[email protected]>
Gerrit-Reviewer: CSteipp <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
