Alex Monk has uploaded a new change for review.
https://gerrit.wikimedia.org/r/130085
Change subject: Fix tab selection on monobook
......................................................................
Fix tab selection on monobook
Don't unselect article tab when loading VE, do unselect when restoring normal
view mode.
Bug: 49407
Change-Id: I4b6e5c898a8af2b404151bba46359dc4bfbd739e
---
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/85/130085/1
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
index 9d4d55d..0c69186 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
@@ -1374,7 +1374,7 @@
var uri;
// Put skin tabs in "edit" mode
- $( $( '#p-views' ).length ? '#p-views' : '#p-cactions' )
+ $( '#p-views' )
.find( 'li.selected' ).removeClass( 'selected' );
$( '#ca-ve-edit' )
.addClass( 'selected' );
@@ -1408,7 +1408,8 @@
// Put skin tabs back in "view" mode
$( $( '#p-views' ).length ? '#p-views' : '#p-cactions' )
.find( 'li.selected' ).removeClass( 'selected' );
- $( '#ca-view' ).addClass( 'selected' );
+ $( $( '#ca-view' ).length ? '#ca-view' : '#p-cactions > .pBody > ul >
li:nth-child(1)' )
+ .addClass( 'selected' );
// Make site notice visible again (if present)
$( '#siteNotice.ve-hide' )
--
To view, visit https://gerrit.wikimedia.org/r/130085
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b6e5c898a8af2b404151bba46359dc4bfbd739e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <kren...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
