jenkins-bot has submitted this change and it was merged.

Change subject: Pass user and user_text to Revision constructor
......................................................................


Pass user and user_text to Revision constructor

This avoids the use of $wgUser in Revision constructor and makes the
dependency on the global visible.

Change-Id: Ief79c9769d28a1adb16abab8da1ec01984d9ef92
---
M includes/Title.php
M includes/WikiPage.php
2 files changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Title.php b/includes/Title.php
index eec4dd6..70d2baa 100644
--- a/includes/Title.php
+++ b/includes/Title.php
@@ -3906,6 +3906,8 @@
                                $redirectRevision = new Revision( array(
                                        'title' => $this, // for determining 
the default content model
                                        'page' => $newid,
+                                       'user_text' => $wgUser->getName(),
+                                       'user' => $wgUser->getId(),
                                        'comment' => $comment,
                                        'content' => $redirectContent ) );
                                $redirectRevision->insertOn( $dbw );
diff --git a/includes/WikiPage.php b/includes/WikiPage.php
index 161125d..128fd82 100644
--- a/includes/WikiPage.php
+++ b/includes/WikiPage.php
@@ -2274,6 +2274,8 @@
                $revision = new Revision( array(
                        'title'      => $this->getTitle(), // for determining 
the default content model
                        'page'       => $this->getId(),
+                       'user_text'  => $user->getName(),
+                       'user'       => $user->getId(),
                        'text'       => $serialized,
                        'length'     => $content->getSize(),
                        'comment'    => $comment,

-- 
To view, visit https://gerrit.wikimedia.org/r/130099
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ief79c9769d28a1adb16abab8da1ec01984d9ef92
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to