BBlack has uploaded a new change for review. https://gerrit.wikimedia.org/r/130336
Change subject: Work around cache explosion from gettingStarted feature ...................................................................... Work around cache explosion from gettingStarted feature Related: https://gerrit.wikimedia.org/r/#/c/130134/1 https://gerrit.wikimedia.org/r/#/q/Ib235e6175ffdd7a17d459d449e047e524e3b8819,n,z We probably want this fixed in MW, but this works around it for now Change-Id: Ice1648d1c240af087992f31781887f561f55b288 --- M templates/varnish/text-common.inc.vcl.erb 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/36/130336/1 diff --git a/templates/varnish/text-common.inc.vcl.erb b/templates/varnish/text-common.inc.vcl.erb index 010b274..eccf7aa 100644 --- a/templates/varnish/text-common.inc.vcl.erb +++ b/templates/varnish/text-common.inc.vcl.erb @@ -36,7 +36,10 @@ /* A session or token cookie will prevent caching if varied on, * move the Cookie header out of the way otherwise */ - if (req.http.Cookie ~ "([sS]ession|Token)=") { + /* gettingStarted exclusion is to work around e.g. enwikigettingStartedUserToken= + * which probably shouldn't end in Token= ... + */ + if (req.http.Cookie ~ "([sS]ession|Token)=" && req.http.Cookie !~ "gettingStarted") { set req.hash_ignore_busy = true; } else { call cookie_munging; -- To view, visit https://gerrit.wikimedia.org/r/130336 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ice1648d1c240af087992f31781887f561f55b288 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: BBlack <bbl...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
