jenkins-bot has submitted this change and it was merged.
Change subject: vector: Apply content text style via .mw-body-content instead
of #bodyContent
......................................................................
vector: Apply content text style via .mw-body-content instead of #bodyContent
Font size, line height and positioning styles related to content
rendering should be re-usable for applying in other contexts.
Not just the #bodyContent div.
The use of classes for content styling has been recommended and generally
agreed upon, specifically in the context of the RFC about scoping site CSS:
https://www.mediawiki.org/wiki/Requests_for_comment/Scoping_site_CSS
This change takes the first step toward introducing a reusable class
throughout the UI to apply content-specific styles where needed.
This also makes it possible to resolve a bug in which VisualEditor
does not receive the correct styles because it creates the edit surface
outside the #bodyContent (but within #content) and had no way to
receive the same styling.
Bug: 63985
Change-Id: I66c56c577bad064261c3e4a62a1c1b2566d53972
(cherry picked from commit 9c8592fe786b399d0a321d65d681ba93abd7ce42)
---
M skins/Vector.php
M skins/vector/components/common.less
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/skins/Vector.php b/skins/Vector.php
index a8d3477..e7a4514 100644
--- a/skins/Vector.php
+++ b/skins/Vector.php
@@ -177,7 +177,7 @@
$this->text( 'pageLanguage' );
?>"><span dir="auto"><?php $this->html( 'title' )
?></span></h1>
<?php $this->html( 'prebodyhtml' ) ?>
- <div id="bodyContent">
+ <div id="bodyContent" class="mw-body-content">
<?php
if ( $this->data['isarticle'] ) {
?>
diff --git a/skins/vector/components/common.less
b/skins/vector/components/common.less
index 76d1873..f70c7a4 100644
--- a/skins/vector/components/common.less
+++ b/skins/vector/components/common.less
@@ -127,7 +127,9 @@
vertical-align: text-bottom;
}
-#bodyContent {
+/* TODO: Remove #bodyContent selector (kept for backwards compatibility with
cached html) */
+#bodyContent,
+.mw-body-content {
position: relative;
line-height: @content-line-height;
font-size: @content-font-size;
--
To view, visit https://gerrit.wikimedia.org/r/130481
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66c56c577bad064261c3e4a62a1c1b2566d53972
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.24wmf2
Gerrit-Owner: Jforrester <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
