Giuseppe Lavagetto has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/130591

Change subject: Move cluster definition to the node level.
......................................................................

Move cluster definition to the node level.

We happen to use the $cluster variable for a few reasons, mainly for
ganglia but also for other things. I will remove all declarations below
node-level as they don't work well with puppet 3; for now I just added
it at node level for testing purposes.

This should not interfere with any functionality however.

Change-Id: I5bd8cea283e1f196378c8ad956b69b1d3be34065
Signed-off-by: Giuseppe Lavagetto <glavage...@wikimedia.org>
---
M manifests/role/applicationserver.pp
M manifests/role/cache.pp
M manifests/site.pp
3 files changed, 82 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/91/130591/1

diff --git a/manifests/role/applicationserver.pp 
b/manifests/role/applicationserver.pp
index c361dcd..6f9c4df 100644
--- a/manifests/role/applicationserver.pp
+++ b/manifests/role/applicationserver.pp
@@ -37,7 +37,7 @@
 #   - $group:
 #       Determines what logical group the host will be a
 #       part of. Used for ganglia. Possibilities are:
-#       appserver, api_appserver, bits_appserver, imagescaler, jobrunner
+#       appserver, api_appserver, bits_appserver, imagescaler, jobrunner, 
videoscaler
 #   - $lvs_pool:
 #       Determines lvsrealserver IP(s) that the host will receive.
 #       From lvs::configuration::$lvs_service_ips
diff --git a/manifests/role/cache.pp b/manifests/role/cache.pp
index 44efefd..b6e22de 100644
--- a/manifests/role/cache.pp
+++ b/manifests/role/cache.pp
@@ -1000,7 +1000,7 @@
         }
 
         $storage_size_main = $::realm ? { 'labs' => 5, default => 300 }
-        
+
         if $cluster_tier == 1 {
             $director_retries = 2
         } else {
diff --git a/manifests/site.pp b/manifests/site.pp
index 444d801..e6a3833 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -60,6 +60,7 @@
         $ganglia_aggregator = true
     }
 
+    $cluster = 'lvs'
     include role::lvs::balancer
 
     interface::add_ip6_mapped { 'main':
@@ -76,6 +77,7 @@
 
 # amssq47 is a text varnish
 node /^amssq47\.esams\.wikimedia\.org$/ {
+    $cluster = 'cache_text'
     include role::cache::text
     include role::cache::ssl::unified
 
@@ -91,6 +93,7 @@
         }
     }
 
+    $cluster = 'cache_text'
     include role::cache::text
 
     interface::add_ip6_mapped { 'main': }
@@ -398,7 +401,7 @@
     }
 
     interface::add_ip6_mapped { 'main': }
-
+    $cluster = 'cache_text'
     include role::cache::text
 }
 
@@ -407,6 +410,7 @@
 
     interface::add_ip6_mapped { 'main': }
 
+    $cluster = "cache_misc"
     include role::cache::misc
 }
 
@@ -415,6 +419,7 @@
 
     interface::add_ip6_mapped { 'main': }
 
+    $cluster = "cache_parsoid"
     include role::cache::parsoid
     include admins::parsoid
 }
@@ -426,6 +431,7 @@
 
     interface::add_ip6_mapped { 'main': }
 
+    $cluster = "cache_parsoid"
     include role::cache::mobile
 }
 
@@ -436,6 +442,7 @@
 
     interface::add_ip6_mapped { 'main': }
 
+    $cluster = "cache_upload"
     include role::cache::upload
 }
 
@@ -446,6 +453,7 @@
 
     interface::add_ip6_mapped { 'main': }
 
+    $cluster = "cache_text"
     include role::cache::text
 }
 
@@ -456,6 +464,7 @@
 
     interface::add_ip6_mapped { 'main': }
 
+    $cluster = 'cache_bits'
     include role::cache::bits
 }
 
@@ -485,6 +494,7 @@
 node /^cp301[1-4]\.esams\.(wikimedia\.org|wmnet)$/ {
     interface::add_ip6_mapped { 'main': }
 
+    $cluster = "cache_mobile"
     include role::cache::mobile
 }
 
@@ -495,6 +505,7 @@
 
     interface::add_ip6_mapped { 'main': }
 
+    $cluster = "cache_bits"
     include role::cache::bits
 }
 
@@ -511,6 +522,7 @@
 
     interface::add_ip6_mapped { 'main': }
 
+    $cluster = "cache_bits"
     include role::cache::bits
     include role::cache::ssl::unified
 }
@@ -522,6 +534,7 @@
 
     interface::add_ip6_mapped { 'main': }
 
+    $cluster = "cache_upload"
     include role::cache::upload
     include role::cache::ssl::unified
 }
@@ -533,6 +546,7 @@
 
     interface::add_ip6_mapped { 'main': }
 
+    $cluster = "cache_text"
     include role::cache::text
     include role::cache::ssl::unified
 }
@@ -544,6 +558,7 @@
 
     interface::add_ip6_mapped { 'main': }
 
+    $cluster = "cache_mobile"
     include role::cache::mobile
     include role::cache::ssl::unified
 }
@@ -574,6 +589,7 @@
 
 # pmtpa dbs
 node /^db(60)\.pmtpa\.wmnet/ {
+    $cluster = 'mysql'
     $ganglia_aggregator = true
     class { 'role::coredb::s1':
         mariadb               => true,
@@ -582,6 +598,7 @@
 }
 
 node /^db(69)\.pmtpa\.wmnet/ {
+    $cluster = 'mysql'
     class { 'role::coredb::s2':
         mariadb               => true,
         innodb_file_per_table => true,
@@ -589,6 +606,7 @@
 }
 
 node /^db(71)\.pmtpa\.wmnet/ {
+    $cluster = 'mysql'
     class { 'role::coredb::s3':
         mariadb               => true,
         innodb_file_per_table => true,
@@ -596,6 +614,7 @@
 }
 
 node /^db(72)\.pmtpa\.wmnet/ {
+    $cluster = 'mysql'
     class { 'role::coredb::s4':
         mariadb               => true,
         innodb_file_per_table => true,
@@ -603,6 +622,7 @@
 }
 
 node /^db(73)\.pmtpa\.wmnet/ {
+    $cluster = 'mysql'
     class { 'role::coredb::s5':
         mariadb               => true,
         innodb_file_per_table => true,
@@ -610,6 +630,7 @@
 }
 
 node /^db(74)\.pmtpa\.wmnet/ {
+    $cluster = 'mysql'
     class { 'role::coredb::s6':
         mariadb               => true,
         innodb_file_per_table => true,
@@ -617,6 +638,7 @@
 }
 
 node /^db(68)\.pmtpa\.wmnet/ {
+    $cluster = 'mysql'
     class { 'role::coredb::s7':
         # Sole mysql 5.1 pmtpa slave
         innodb_file_per_table => true,
@@ -630,6 +652,7 @@
 
 # eqiad dbs
 node /^db10(43|49|50|51|52|55|56|61|62)\.eqiad\.wmnet/ {
+    $cluster = 'mysql'
     class { 'role::coredb::s1':
         innodb_file_per_table => true,
         mariadb               => true,
@@ -637,6 +660,7 @@
 }
 
 node /^db10(02|09|18|36|60|63)\.eqiad\.wmnet/ {
+    $cluster = 'mysql'
     class { 'role::coredb::s2':
         innodb_file_per_table => true,
         mariadb               => true,
@@ -644,6 +668,7 @@
 }
 
 node /^db10(03|19|35|38)\.eqiad\.wmnet/ {
+    $cluster = 'mysql'
     class { 'role::coredb::s3':
         # Many more tables than other shards.
         # innodb_file_per_table=off to reduce file handles.
@@ -653,6 +678,7 @@
 }
 
 node /^db10(04|11|20|40|42|59)\.eqiad\.wmnet/ {
+    $cluster = 'mysql'
     class { 'role::coredb::s4':
         innodb_file_per_table => true,
         mariadb               => true,
@@ -663,6 +689,7 @@
     if $::hostname =~ /^db1021/ {
         $ganglia_aggregator = true
     }
+    $cluster = 'mysql'
     class { 'role::coredb::s5':
         innodb_file_per_table => true,
         mariadb               => true,
@@ -670,6 +697,7 @@
 }
 
 node /^db10(06|10|15|22|23|30)\.eqiad\.wmnet/ {
+    $cluster = 'mysql'
     class { 'role::coredb::s6':
         innodb_file_per_table => true,
         mariadb               => true,
@@ -677,6 +705,7 @@
 }
 
 node /^db10(07|28|33|34|39|41)\.eqiad\.wmnet/ {
+    $cluster = 'mysql'
     class { 'role::coredb::s7':
         innodb_file_per_table => true,
         mariadb               => true,
@@ -685,11 +714,13 @@
 
 ## x1 shard
 node /^db10(29|31)\.eqiad\.wmnet/ {
+    $cluster = 'mysql'
     include role::coredb::x1
 }
 
 ## m1 shard
 node /^db10(01|16)\.eqiad\.wmnet/ {
+    $cluster = 'mysql'
     class { 'role::coredb::m1':
         mariadb => true,
     }
@@ -697,6 +728,7 @@
 
 ## m2 shard
 node /^db104[68]\.eqiad\.wmnet/ {
+    $cluster = 'mysql'
     if $::hostname =~ /^db1048/ {
         $ganglia_aggregator = true
     }
@@ -711,11 +743,13 @@
 
 ## researchdb s1
 node 'db1047.eqiad.wmnet' {
+    $cluster = 'mysql'
     include role::mariadb::analytics
 }
 
 ## researchdb s5
 node 'db1017.eqiad.wmnet' {
+    $cluster = 'mysql'
     class { 'role::coredb::researchdb':
         shard                 => 's5',
         mariadb               => true,
@@ -726,6 +760,7 @@
 
 ## SANITARIUM
 node 'db1053.eqiad.wmnet' {
+    $cluster = 'mysql'
     class { 'role::db::sanitarium':
         instances => {
             's1' => {
@@ -741,6 +776,7 @@
 }
 
 node 'db1054.eqiad.wmnet' {
+    $cluster = 'mysql'
     class { 'role::db::sanitarium':
         instances => {
             's2' => {
@@ -772,6 +808,7 @@
 }
 
 node 'db1057.eqiad.wmnet' {
+    $cluster = 'mysql'
     class { 'role::db::sanitarium':
         instances => {
             's3' => {
@@ -804,10 +841,12 @@
 }
 
 node 'db1044.eqiad.wmnet' {
+    $cluster = 'mysql'
     include role::mariadb::tendril
 }
 
 node /^dbstore100(1|2)\.eqiad\.wmnet/ {
+    $cluster = 'mysql'
     include role::mariadb::dbstore
 }
 
@@ -867,6 +906,7 @@
 }
 
 node 'aluminium.wikimedia.org' {
+    $cluster = 'fundraising'
     include role::fundraising::civicrm
     include accounts::file_mover
 
@@ -885,22 +925,26 @@
 
 # es1 equad
 node /es100[1-4]\.eqiad\.wmnet/ {
+    $cluster = 'mysql'
     class { 'role::coredb::es1':
         mariadb => true,
     }
 }
 
 node /es4\.pmtpa\.wmnet/ {
+    $cluster = 'mysql'
     include role::coredb::es1
 }
 
 # es2-3
 node /es7\.pmtpa\.wmnet/ {
-  include role::coredb::es2
+    $cluster = 'mysql'
+    include role::coredb::es2
 }
 
 node /es8\.pmtpa\.wmnet/ {
-  include role::coredb::es3
+    $cluster = 'mysql'
+    include role::coredb::es3
 }
 
 ## imminent decomission/reclaim from pmtpa pending 12th floor reorg
@@ -909,6 +953,7 @@
 }
 
 node /es100[5-7]\.eqiad\.wmnet/ {
+    $cluster = 'mysql'
     if $::hostname =~ /^es100[67]/ {
         class { 'role::coredb::es2':
             mariadb => true,
@@ -919,6 +964,7 @@
 }
 
 node /es10(0[89]|10)\.eqiad\.wmnet/ {
+    $cluster = 'mysql'
     if $::hostname =~ /^es10(09|10)/ {
         class { 'role::coredb::es3':
             mariadb => true,
@@ -1186,6 +1232,7 @@
 
 ## labsdb dbs
 node 'labsdb1001.eqiad.wmnet' {
+    $cluster = 'mysql'
     class { 'role::db::labsdb':
         instances => {
             's1' => {
@@ -1203,6 +1250,7 @@
 }
 
 node 'labsdb1002.eqiad.wmnet' {
+    $cluster = 'mysql'
     class { 'role::db::labsdb':
         instances => {
             's2' => {
@@ -1246,6 +1294,7 @@
 }
 
 node 'labsdb1003.eqiad.wmnet' {
+    $cluster = 'mysql'
     class { 'role::db::labsdb':
         instances => {
             's3' => {
@@ -1389,7 +1438,7 @@
     if $::hostname =~ /^lvs100[25]$/ {
         $nameservers_prefix = [ '208.80.154.157', '208.80.154.50' ]
     }
-
+    $cluster = 'lvs'
     include role::lvs::balancer
 
     interface::add_ip6_mapped { 'main':
@@ -1515,7 +1564,7 @@
 #    if $::hostname =~ /^lvs300[13]$/ {
 #        $ganglia_aggregator = true
 #    }
-
+    $cluster = 'lvs'
     include role::lvs::balancer
 
     interface::add_ip6_mapped { 'main':
@@ -1539,6 +1588,7 @@
 
 # ULSFO lvs servers
 node /^lvs400[1-4]\.ulsfo\.wmnet$/ {
+    $cluster = 'lvs'
     # lvs4001 and lvs4003 are in different racks
     if $::hostname =~ /^lvs400[13]$/ {
         $ganglia_aggregator = true
@@ -1598,6 +1648,7 @@
 }
 
 node /^rdb100[1-4]\.eqiad\.wmnet/ {
+    $cluster = 'redis'
     $ganglia_aggregator = true
 
     $redis_replication = {
@@ -1682,6 +1733,7 @@
 }
 
 node /^ms-fe100[1-4]\.eqiad\.wmnet$/ {
+    $cluster = 'swift'
     if $::hostname =~ /^ms-fe100[12]$/ {
         $ganglia_aggregator = true
     }
@@ -1695,6 +1747,7 @@
 }
 
 node /^ms-be10[0-9][0-9]\.eqiad\.wmnet$/ {
+    $cluster = 'swift'
     $all_drives = [
         '/dev/sda', '/dev/sdb', '/dev/sdc', '/dev/sdd',
         '/dev/sde', '/dev/sdf', '/dev/sdg', '/dev/sdh',
@@ -1716,6 +1769,7 @@
 }
 
 node /^ms-be300[1-4]\.esams\.wmnet$/ {
+    $cluster = 'swift'
     # 720xd *without* SSDs; sda & sdb serve both as root and as Swift disks
     $all_drives = [
         '/dev/sdc', '/dev/sdd', '/dev/sde', '/dev/sdf',
@@ -1736,6 +1790,7 @@
 
 # mw1001-1016 are jobrunners (precise)
 node /^mw10(0[1-9]|1[0-6])\.eqiad\.wmnet$/ {
+    $cluster = 'jobrunner'
     if $::hostname =~ /^mw100[12]$/ {
         $ganglia_aggregator = true
     }
@@ -1752,6 +1807,7 @@
 
 # mw1017-1113 are apaches (precise)
 node /^mw1(01[7-9]|0[2-9][0-9]|10[0-9]|11[0-3])\.eqiad\.wmnet$/ {
+    $cluster = 'appserver'
     if $::hostname =~ /^mw101[78]$/ {
         $ganglia_aggregator = true
     }
@@ -1771,6 +1827,7 @@
 
 # mw1114-1148 are api apaches (precise)
 node /^mw11(1[4-9]|[23][0-9]|4[0-8])\.eqiad\.wmnet$/ {
+    $cluster = 'api_appserver'
     if $::hostname =~ /^mw111[45]$/ {
         $ganglia_aggregator = true
     }
@@ -1780,6 +1837,7 @@
 
 # mw1149-1152 are bits apaches (precise)
 node /^mw11(49|5[0-2])\.eqiad\.wmnet$/ {
+    $cluster = 'bits_appserver'
     if $::hostname =~ /^mw115[12]$/ {
         $ganglia_aggregator = true
     }
@@ -1789,6 +1847,7 @@
 
 # mw1153-1160 are imagescalers (precise)
 node /^mw11(5[3-9]|60)\.eqiad\.wmnet$/ {
+    $cluster = 'imagescaler'
     if $::hostname =~ /^mw115[34]$/ {
         $ganglia_aggregator = true
     }
@@ -1798,7 +1857,7 @@
 
 # mw1161-1188 are apaches (precise)
 node /^mw11(6[1-9]|7[0-9]|8[0-8])\.eqiad\.wmnet$/ {
-
+    $cluster = 'appserver'
     if $::hostname == 'mw1161' {
         include misc::deployment::scap_proxy
     }
@@ -1808,7 +1867,7 @@
 
 # mw1189-1208 are api apaches (precise)
 node /^mw1(189|19[0-9]|20[0-8])\.eqiad\.wmnet$/ {
-
+    $cluster = 'api_appserver'
     if $::hostname == 'mw1201' {
         include misc::deployment::scap_proxy
     }
@@ -1818,7 +1877,7 @@
 
 # mw1209-1220 are apaches (precise)
 node /^mw12(09|1[0-9]|20)\.eqiad\.wmnet$/ {
-
+    $cluster = 'appserver'
     include role::applicationserver::appserver
 }
 
@@ -1998,7 +2057,7 @@
 }
 
 node /pc100[1-3]\.eqiad\.wmnet/ {
-
+    $cluster = 'mysql'
     include role::db::core
     include mysql_wmf::mysqluser
     include mysql_wmf::datadirs
@@ -2069,6 +2128,7 @@
 }
 
 node /^search100[0-6]\.eqiad\.wmnet/ {
+    $cluster = 'search'
     if $::hostname =~ /^search100(1|2)$/ {
         $ganglia_aggregator = true
     }
@@ -2077,42 +2137,42 @@
 }
 
 node /^search10(0[7-9]|10)\.eqiad\.wmnet/ {
-
+    $cluster = 'search'
     include role::lucene::front_end::pool2
 }
 
 node /^search101[1-4]\.eqiad\.wmnet/ {
-
+    $cluster = 'search'
     include role::lucene::front_end::pool3
 }
 
 node /^search101[56]\.eqiad\.wmnet/ {
-
+    $cluster = 'search'
     include role::lucene::front_end::pool4
 }
 
 node /^search10(19|20)\.eqiad\.wmnet/ {
-
+    $cluster = 'search'
     include role::lucene::front_end::pool5
 }
 
 node /^search101[78]\.eqiad\.wmnet/ {
-
+    $cluster = 'search'
     include role::lucene::front_end::prefix
 }
 
 node /^search10(19|2[0-2])\.eqiad\.wmnet/ {
-
+    $cluster = 'search'
     include role::lucene::front_end::pool4
 }
 
 node /^search102[3-4]\.eqiad\.wmnet/ {
-
+    $cluster = 'search'
     include role::lucene::front_end::pool3
 }
 
 node /^searchidx100[0-2]\.eqiad\.wmnet/ {
-
+    $cluster = 'search'
     include role::lucene::indexer
 }
 
@@ -2180,6 +2240,7 @@
 }
 
 node /ssl100[1-9]\.wikimedia\.org/ {
+    $cluster = 'ssl'
     if $::hostname =~ /^ssl100[12]$/ {
         $ganglia_aggregator = true
     }
@@ -2192,6 +2253,7 @@
 }
 
 node /ssl300[1-4]\.esams\.wikimedia\.org/ {
+    $cluster = 'ssl'
     if $::hostname =~ /^ssl300[12]$/ {
         $ganglia_aggregator = true
     }
@@ -2499,6 +2561,7 @@
 
 # tmh1001/tmh1002 video encoding server (precise only)
 node /^tmh100[1-2]\.eqiad\.wmnet/ {
+    $cluster = 'videoscaler'
     if $::hostname =~ /^tmh100[12]$/ {
         $ganglia_aggregator = true
     }

-- 
To view, visit https://gerrit.wikimedia.org/r/130591
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5bd8cea283e1f196378c8ad956b69b1d3be34065
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Giuseppe Lavagetto <glavage...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to