Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/131593
Change subject: Fix round trip tests in MwTimeIsoFormatter tests
......................................................................
Fix round trip tests in MwTimeIsoFormatter tests
This part of the tests was never exectued. This looks like a
mistake to me. If I turn it on it runs with no problem.
Change-Id: I76f3cdafb38be1964e6ed91b617911ee123efd28
---
M lib/tests/phpunit/formatters/MwTimeIsoFormatterTest.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/93/131593/1
diff --git a/lib/tests/phpunit/formatters/MwTimeIsoFormatterTest.php
b/lib/tests/phpunit/formatters/MwTimeIsoFormatterTest.php
index b1857ac..3233d74 100644
--- a/lib/tests/phpunit/formatters/MwTimeIsoFormatterTest.php
+++ b/lib/tests/phpunit/formatters/MwTimeIsoFormatterTest.php
@@ -303,7 +303,7 @@
foreach ( $tests as $expected => $args ) {
$timeValue = new TimeValue( $args[0], 0, 0, 0,
$args[1], TimeFormatter::CALENDAR_GREGORIAN );
- $argLists[] = array( $expected, $timeValue );
+ $argLists[] = array( $expected, $timeValue, !empty(
$args[2] ) );
}
// Different languages at year precision
--
To view, visit https://gerrit.wikimedia.org/r/131593
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I76f3cdafb38be1964e6ed91b617911ee123efd28
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
