jenkins-bot has submitted this change and it was merged.
Change subject: Only show anonymous editor acquisition once to the user.
......................................................................
Only show anonymous editor acquisition once to the user.
Change-Id: If07df9436e4de1990942223a6d8764f6e16b4f20
---
M GettingStarted.php
M resources/ext.gettingstarted.anonymousEditorAcquisition.js
2 files changed, 7 insertions(+), 1 deletion(-)
Approvals:
Phuedx: Looks good to me, approved
jenkins-bot: Verified
diff --git a/GettingStarted.php b/GettingStarted.php
index 005de1f..166de2c 100644
--- a/GettingStarted.php
+++ b/GettingStarted.php
@@ -295,6 +295,7 @@
'ext.gettingstarted.user',
'schema.SignupExpPageLinkClick',
'ext.guidedTour.lib',
+ 'jquery.jStorage',
),
'messages' => array(
'guidedtour-tour-anonymouseditoracquisitionpostedit-title',
diff --git a/resources/ext.gettingstarted.anonymousEditorAcquisition.js
b/resources/ext.gettingstarted.anonymousEditorAcquisition.js
index 9c070e2..c95dec2 100644
--- a/resources/ext.gettingstarted.anonymousEditorAcquisition.js
+++ b/resources/ext.gettingstarted.anonymousEditorAcquisition.js
@@ -170,7 +170,6 @@
$( function () {
var isPreEdit = bucket === 'pre-edit';
-
// In the pre-edit variant, clicking "edit" or "edit source"
// shows a guider so don't follow the link after the
// SignupExpPageLinkClick event has been logged.
@@ -179,6 +178,12 @@
logLinkClick( '#pt-createaccount', 'create account' );
+ // Only init if user has not seen CTA.
+ if ( $.jStorage.get( 'hasShownAnonymousEditorAcquisitionCTA' )
) {
+ return;
+ }
+ $.jStorage.set( 'hasShownAnonymousEditorAcquisitionCTA', true );
+
if ( isPreEdit ) {
initPreEditVariant();
} else if ( bucket === 'post-edit' ) {
--
To view, visit https://gerrit.wikimedia.org/r/132018
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If07df9436e4de1990942223a6d8764f6e16b4f20
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: master
Gerrit-Owner: Robmoen <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Phuedx <[email protected]>
Gerrit-Reviewer: Swalling <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
