jenkins-bot has submitted this change and it was merged.

Change subject: Repair removeFromToolbar() to handle image buttons
......................................................................


Repair removeFromToolbar() to handle image buttons

Bug: 29440
Change-Id: Ic30af1a1d5842a8f330344eb4a10ecbdc2606fc5
---
M modules/jquery.wikiEditor.toolbar.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/jquery.wikiEditor.toolbar.js 
b/modules/jquery.wikiEditor.toolbar.js
index 02d2042..0d1ce0a 100644
--- a/modules/jquery.wikiEditor.toolbar.js
+++ b/modules/jquery.wikiEditor.toolbar.js
@@ -158,7 +158,7 @@
                                        // Save for later checking if empty
                                        group = target;
                                        // Tool
-                                       target += ' a[rel="' + data.tool + 
'"].tool';
+                                       target = group + ' a[rel="' + data.tool 
+ '"].tool, ' + group + ' img[rel="' + data.tool + '"].tool';
                                }
                        } else if ( typeof data.page === 'string' ) {
                                // Booklet page

-- 
To view, visit https://gerrit.wikimedia.org/r/124503
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic30af1a1d5842a8f330344eb4a10ecbdc2606fc5
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: TheDJ <hartman.w...@gmail.com>
Gerrit-Reviewer: Bartosz DziewoƄski <matma....@gmail.com>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: Mattflaschen <mflasc...@wikimedia.org>
Gerrit-Reviewer: Mwalker <mwal...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to