Yuvipanda has uploaded a new change for review.
https://gerrit.wikimedia.org/r/132627
Change subject: Add instrumentation for ToC usage
......................................................................
Add instrumentation for ToC usage
Change-Id: I548f4dbae1e8a1e79a93e0a9f775547de87f134a
---
M wikipedia/src/main/java/org/wikipedia/page/ToCHandler.java
1 file changed, 6 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/27/132627/1
diff --git a/wikipedia/src/main/java/org/wikipedia/page/ToCHandler.java
b/wikipedia/src/main/java/org/wikipedia/page/ToCHandler.java
index b8d4f48..5a977e8 100644
--- a/wikipedia/src/main/java/org/wikipedia/page/ToCHandler.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/ToCHandler.java
@@ -9,6 +9,7 @@
import com.nineoldandroids.view.ViewHelper;
import org.json.*;
import org.wikipedia.*;
+import org.wikipedia.analytics.*;
import org.wikipedia.bridge.*;
import org.wikipedia.styledviews.DisableableDrawerLayout;
@@ -17,13 +18,11 @@
public class ToCHandler {
private final ListView tocList;
private final ProgressBar tocProgress;
- private Page page;
- private final View quickReturnBar;
private final CommunicationBridge bridge;
private final DisableableDrawerLayout slidingPane;
+ private ToCInteractionFunnel funnel;
public ToCHandler(final DisableableDrawerLayout slidingPane, final View
quickReturnBar, final CommunicationBridge bridge) {
- this.quickReturnBar = quickReturnBar;
this.bridge = bridge;
this.slidingPane = slidingPane;
@@ -39,12 +38,14 @@
prevTranslateY = ViewHelper.getTranslationY(quickReturnBar);
bridge.sendMessage("requestCurrentSection", new JSONObject());
ViewAnimations.ensureTranslationY(quickReturnBar,
-quickReturnBar.getHeight());
+ funnel.logOpen();
}
@Override
public void onDrawerClosed(View drawerView) {
super.onDrawerClosed(drawerView);
ViewAnimations.ensureTranslationY(quickReturnBar, (int)
prevTranslateY);
+ funnel.logClose();
}
@Override
@@ -67,10 +68,10 @@
}
public void setupToC(final Page page) {
- this.page = page;
tocProgress.setVisibility(View.GONE);
tocList.setVisibility(View.VISIBLE);
+ funnel = new
ToCInteractionFunnel((WikipediaApp)slidingPane.getContext().getApplicationContext(),
page.getTitle().getSite());
bridge.addListener("currentSectionResponse", new
CommunicationBridge.JSEventListener() {
@Override
public void onMessage(String messageType, JSONObject
messagePayload) {
@@ -101,6 +102,7 @@
public void onItemClick(AdapterView<?> parent, View view, int
position, long id) {
Section section = (Section)
parent.getAdapter().getItem(position);
scrollToSection(section);
+ funnel.logClick();
hide();
}
});
@@ -124,8 +126,6 @@
private static final class ToCAdapter extends BaseAdapter {
private final ArrayList<Section> sections;
- private final PageTitle title;
-
private ToCAdapter(Page page) {
sections = new ArrayList<Section>();
@@ -134,7 +134,6 @@
sections.add(s);
}
}
- this.title = page.getTitle();
}
@Override
--
To view, visit https://gerrit.wikimedia.org/r/132627
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I548f4dbae1e8a1e79a93e0a9f775547de87f134a
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
