jenkins-bot has submitted this change and it was merged.
Change subject: code cleanup: return silently from methods
......................................................................
code cleanup: return silently from methods
Page.put() and Page.put_async() aren't functions in core. We can
return from these methods silently.
Change-Id: I916940e4e92334741fc87102bc102461c4e8fba4
---
M pywikibot/page.py
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Merlijn van Deen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/page.py b/pywikibot/page.py
index 848f748..0c765ce 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -932,9 +932,9 @@
"""
self.text = newtext
- return self.save(comment=comment, watch=watchArticle,
- minor=minorEdit, botflag=botflag, force=force,
- async=async, callback=callback, **kwargs)
+ self.save(comment=comment, watch=watchArticle, minor=minorEdit,
+ botflag=botflag, force=force, async=async, callback=callback,
+ **kwargs)
def put_async(self, newtext, comment=u'', watchArticle=None,
minorEdit=True, botflag=None, force=False, callback=None,
@@ -947,9 +947,9 @@
backwards-compatibility.
"""
- return self.put(newtext, comment=comment, watchArticle=watchArticle,
- minorEdit=minorEdit, botflag=botflag, force=force,
- async=True, callback=callback, **kwargs)
+ self.put(newtext, comment=comment, watchArticle=watchArticle,
+ minorEdit=minorEdit, botflag=botflag, force=force, async=True,
+ callback=callback, **kwargs)
def watch(self, unwatch=False):
"""Add or remove this page to/from bot account's watchlist.
--
To view, visit https://gerrit.wikimedia.org/r/132786
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I916940e4e92334741fc87102bc102461c4e8fba4
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <i...@gno.de>
Gerrit-Reviewer: Ladsgroup <ladsgr...@gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhall...@arctus.nl>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
