jenkins-bot has submitted this change and it was merged.
Change subject: Simplify thumbnail styling to have consistency with mobile
implementation
......................................................................
Simplify thumbnail styling to have consistency with mobile implementation
Remove undocumented !important rule - !important is bad.
Bug: 65160
Change-Id: I21d6856d51478395cbe59e86e2f3aec495a74a38
---
M skins/common/commonContent.css
A skins/vector/components/thumbnails.less
M skins/vector/screen.less
3 files changed, 34 insertions(+), 1 deletion(-)
Approvals:
JGonera: Looks good to me, approved
jenkins-bot: Verified
diff --git a/skins/common/commonContent.css b/skins/common/commonContent.css
index 4157b55..6bf01ae 100644
--- a/skins/common/commonContent.css
+++ b/skins/common/commonContent.css
@@ -143,7 +143,7 @@
html .thumbcaption {
border: none;
line-height: 1.4em;
- padding: 3px !important;
+ padding: 3px;
font-size: 94%;
}
diff --git a/skins/vector/components/thumbnails.less
b/skins/vector/components/thumbnails.less
new file mode 100644
index 0000000..afb5f2a
--- /dev/null
+++ b/skins/vector/components/thumbnails.less
@@ -0,0 +1,32 @@
+// FIXME: Due to commonContent.css we have to use html tag to make sure these
are more specific
+html .thumb {
+ &.tright {
+ padding: 1px 0 0 15px;
+ }
+
+ &.tleft {
+ padding: 1px 15px 0 0;
+ }
+
+ // these resets should be unnecessary
+ div.thumbinner {
+ border: none;
+ background: none;
+ font-size: 100%;
+ }
+
+ .thumbcaption {
+ line-height: @content-line-height;
+ font-size: .85em;
+ padding: 3px 0 0 0;
+ color: #333;
+ }
+
+ .magnify {
+ display: none;
+ }
+
+ .thumbimage {
+ border: none;
+ }
+}
diff --git a/skins/vector/screen.less b/skins/vector/screen.less
index f7b374f..3e824f33 100644
--- a/skins/vector/screen.less
+++ b/skins/vector/screen.less
@@ -8,3 +8,4 @@
@import "components/footer.less";
@import 'components/notifications.less';
@import "components/externalLinks.less";
+@import "components/thumbnails.less";
--
To view, visit https://gerrit.wikimedia.org/r/123815
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I21d6856d51478395cbe59e86e2f3aec495a74a38
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Daniel Friesen <dan...@nadir-seen-fire.com>
Gerrit-Reviewer: Edokter <er...@darcoury.nl>
Gerrit-Reviewer: JGonera <jgon...@wikimedia.org>
Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: Jaredzimmerman <jared.zimmer...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Nemo bis <federicol...@tiscali.it>
Gerrit-Reviewer: Quiddity <pandiculat...@gmail.com>
Gerrit-Reviewer: Swalling <swall...@wikimedia.org>
Gerrit-Reviewer: TheDJ <hartman.w...@gmail.com>
Gerrit-Reviewer: Waldir <wal...@email.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
