Thiemo Mättig (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/132944

Change subject: Don't underline hovercard text when user preference is 'Always'
......................................................................

Don't underline hovercard text when user preference is 'Always'

The setting is called 'underline' and defaults to 'Skin or
browser default' (= 2). If set to 'Always' (= 1), which is what
I personally like and do, ;-) all text in hovercards is
underlined (and the underlines disappear if you hover the
hovercard, which is a bit tricky but possible).

This simple fix removes the dependency from the default style
(which only shows underlines on hover). I think this is the most
straightforward solution.

Change-Id: Ide54ffd1949a50184d8d2a680bf1a0d35e24d563
---
M resources/ext.popups.core.less
1 file changed, 1 insertion(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/44/132944/1

diff --git a/resources/ext.popups.core.less b/resources/ext.popups.core.less
index 8b41f43..edc2762 100644
--- a/resources/ext.popups.core.less
+++ b/resources/ext.popups.core.less
@@ -41,10 +41,7 @@
                margin-top: -9px;
                padding-top: 9px;
                color: #000;
-
-               &:hover {
-                       text-decoration: none;
-               }
+               text-decoration: none;
 
                > div {
                        padding: 0;

-- 
To view, visit https://gerrit.wikimedia.org/r/132944
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide54ffd1949a50184d8d2a680bf1a0d35e24d563
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to