jenkins-bot has submitted this change and it was merged. Change subject: Cleanup in ApiClientInfo and test ......................................................................
Cleanup in ApiClientInfo and test Change-Id: I4814e119f14ed4b7b4123b83ea357fbce9e5c74e --- M client/includes/api/ApiClientInfo.php M client/tests/phpunit/includes/api/ApiClientInfoTest.php 2 files changed, 19 insertions(+), 7 deletions(-) Approvals: Hoo man: Looks good to me, approved WikidataJenkins: Verified jenkins-bot: Verified diff --git a/client/includes/api/ApiClientInfo.php b/client/includes/api/ApiClientInfo.php index 48f1f8c..7f46cea 100644 --- a/client/includes/api/ApiClientInfo.php +++ b/client/includes/api/ApiClientInfo.php @@ -4,6 +4,7 @@ use ApiBase; use ApiQuery; +use ApiQueryBase; use Wikibase\Client\WikibaseClient; /** @@ -16,7 +17,7 @@ * @licence GNU GPL v2+ * @author Katie Filbert < [email protected] > */ -class ApiClientInfo extends \ApiQueryBase { +class ApiClientInfo extends ApiQueryBase { /** * @var SettingsArray @@ -154,7 +155,7 @@ /** * @see ApiBase::getDescription * - * @since 0.4i + * @since 0.4 * * @return string */ diff --git a/client/tests/phpunit/includes/api/ApiClientInfoTest.php b/client/tests/phpunit/includes/api/ApiClientInfoTest.php index 3dd37bf..b8e94cf 100644 --- a/client/tests/phpunit/includes/api/ApiClientInfoTest.php +++ b/client/tests/phpunit/includes/api/ApiClientInfoTest.php @@ -2,7 +2,12 @@ namespace Wikibase\Test; +use ApiMain; +use ApiTestContext; use ApiQuery; +use FauxRequest; +use MediaWikiTestCase; +use User; use Wikibase\SettingsArray; use Wikibase\ApiClientInfo; @@ -20,23 +25,29 @@ * @licence GNU GPL v2+ * @author Katie Filbert < [email protected] > */ -class ApiClientInfoTest extends \MediaWikiTestCase { +class ApiClientInfoTest extends MediaWikiTestCase { protected $apiContext; public function setUp() { parent::setUp(); - $this->apiContext = new \ApiTestContext(); + $this->apiContext = new ApiTestContext(); } + /** + * @param array $params + * @param SettingsArray $settings + * + * @return ApiClientInfo + */ public function getApiModule( array $params, SettingsArray $settings ) { - $request = new \FauxRequest( $params, true ); + $request = new FauxRequest( $params, true ); - $user = \User::newFromName( 'zombie' ); + $user = User::newFromName( 'zombie' ); $context = $this->apiContext->newTestContext( $request, $user ); - $apiMain = new \ApiMain( $context, true ); + $apiMain = new ApiMain( $context, true ); $apiQuery = new ApiQuery( $apiMain, 'wikibase' ); $apiModule = new ApiClientInfo( $apiQuery, 'query' ); -- To view, visit https://gerrit.wikimedia.org/r/133905 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4814e119f14ed4b7b4123b83ea357fbce9e5c74e Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude <[email protected]> Gerrit-Reviewer: Addshore <[email protected]> Gerrit-Reviewer: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Hoo man <[email protected]> Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]> Gerrit-Reviewer: WikidataJenkins <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
