Reedy has submitted this change and it was merged. Change subject: (bug 20272) Make AbortAutoAccount useful for other extensions. ......................................................................
(bug 20272) Make AbortAutoAccount useful for other extensions. Before this change AbortAutoAccount was called on empty User object, so the extensions were unable to even check the user name of created account. This change moves User object initialisation before hook is called, so User object is at least populated with user name. There is also additional check if the user name was changed by one of the hooks. Custom CentralAuthAutoCreate is now marked as deprecated as extensions should use generic AbortAutoAccount. If autocreation is stopped by a hook, the wiki is added to blacklist, so expensive checks won't be run on every page refresh. According to a comment in the code, the user is still able to use Special:UserLogin. Change-Id: I92f57fc2c3189c42157478de14a8d48045a253b5 --- M CentralAuthHooks.php 1 file changed, 14 insertions(+), 3 deletions(-) Approvals: CSteipp: Looks good to me, but someone else must approve Reedy: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/7037 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92f57fc2c3189c42157478de14a8d48045a253b5 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/CentralAuth Gerrit-Branch: master Gerrit-Owner: Szymon Świerkosz <[email protected]> Gerrit-Reviewer: Brion VIBBER <[email protected]> Gerrit-Reviewer: CSteipp <[email protected]> Gerrit-Reviewer: Reedy <[email protected]> Gerrit-Reviewer: Szymon Świerkosz <[email protected]> Gerrit-Reviewer: Victor Vasiliev <[email protected]> Gerrit-Reviewer: jan <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
