Daniel Werner has uploaded a new change for review. Change subject: Fix for failing QUnit test for EditableValue ......................................................................
Fix for failing QUnit test for EditableValue This test was actually wrong before. The initial EditableValue was empty but was not recognized as empty because the given DOM structure was wrong, so the toolbar ended up as the value. In the past this was not detected and led to false conditions, so the tests made false assumptions. This is fixed now and the initial test for testing faked API failures has been adjusted to work now. Change-Id: Ib27359d2dc56f2b902332da7ce4cbc7bf389b22d --- M repo/tests/qunit/wikibase.ui.PropertyEditTool.EditableValue.tests.js 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/46/26646/1 -- To view, visit https://gerrit.wikimedia.org/r/26646 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib27359d2dc56f2b902332da7ce4cbc7bf389b22d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
