Hoo man has uploaded a new change for review.
https://gerrit.wikimedia.org/r/134815
Change subject: Pass GET parameters into mw.Title.getUrl
......................................................................
Pass GET parameters into mw.Title.getUrl
We don't support MediaWiki 1.22
Change-Id: Idae5fd080912887c18633890db7cee19439c2d6e
---
M repo/resources/wikibase.ui.initTermBox.js
1 file changed, 2 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/15/134815/1
diff --git a/repo/resources/wikibase.ui.initTermBox.js
b/repo/resources/wikibase.ui.initTermBox.js
index df237f9..0f471c4 100644
--- a/repo/resources/wikibase.ui.initTermBox.js
+++ b/repo/resources/wikibase.ui.initTermBox.js
@@ -127,8 +127,7 @@
for( var i = 0; i < languageCodes.length; i++ ) {
var languageCode = languageCodes[i],
- alternatingClass = i % 2 ? 'even' : 'uneven',
- url = title.getUrl();
+ alternatingClass = i % 2 ? 'even' : 'uneven';
$tbody.append( mw.template( 'wb-term',
languageCode,
@@ -140,11 +139,7 @@
'',
'',
'',
- // FIXME: Change this to
- // title.getUrl( { setlang: languageCode } )
- // when Wikibase minimum MediaWiki version is
1.23.
- url + ( url.indexOf( '?' ) !== -1 ? '&' : '?' )
- + $.param( { setlang: languageCode } )
+ title.getUrl( { setlang: languageCode } )
) );
}
--
To view, visit https://gerrit.wikimedia.org/r/134815
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idae5fd080912887c18633890db7cee19439c2d6e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <h...@online.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
