jenkins-bot has submitted this change and it was merged.
Change subject: Popups: The promise of the popups was not forwarding failures
......................................................................
Popups: The promise of the popups was not forwarding failures
Change-Id: Icc1d5a175ccf9ef000dd198f999994917912de3f
---
M resources/ext.popups.renderer.article.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Prtksxna: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/ext.popups.renderer.article.js
b/resources/ext.popups.renderer.article.js
index 4638ca0..bf7cf78 100644
--- a/resources/ext.popups.renderer.article.js
+++ b/resources/ext.popups.renderer.article.js
@@ -52,6 +52,7 @@
titles: title
} );
+ mw.popups.render.currentRequest.fail( deferred.reject );
mw.popups.render.currentRequest.done( function ( re ) {
mw.popups.render.currentRequest = undefined;
@@ -59,7 +60,8 @@
!re.query.pages[ re.query.pageids[ 0 ]
].extract ||
re.query.pages[ re.query.pageids[ 0 ] ].extract
=== ''
) {
- return false;
+ deferred.reject();
+ return;
}
mw.popups.render.cache[ href ] = {};
--
To view, visit https://gerrit.wikimedia.org/r/134267
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc1d5a175ccf9ef000dd198f999994917912de3f
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: TheDJ <hartman.w...@gmail.com>
Gerrit-Reviewer: Prtksxna <psax...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
