jenkins-bot has submitted this change and it was merged.

Change subject: Documentation for Data Type to Data Value Type mapping
......................................................................


Documentation for Data Type to Data Value Type mapping

Change-Id: I8caed8af113b3c6a748548f974ebd7cee2edd951
---
M lib/includes/WikibaseDataTypeBuilders.php
1 file changed, 19 insertions(+), 6 deletions(-)

Approvals:
  WikidataJenkins: Verified
  Daniel Kinzler: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/lib/includes/WikibaseDataTypeBuilders.php 
b/lib/includes/WikibaseDataTypeBuilders.php
index b0d9d2f..a73094f 100644
--- a/lib/includes/WikibaseDataTypeBuilders.php
+++ b/lib/includes/WikibaseDataTypeBuilders.php
@@ -71,14 +71,27 @@
                //     the dataTypes setting. On the other hand, perhaps that 
setting should only
                //     be used for the UI, and the factory should simply know 
all data types always.
 
+               /**
+                * Data types to data value types mapping:
+                * commonsMedia     => string (camel case, FIXME maybe?)
+                * globe-coordinate => globecoordinate (FIXME!)
+                * monolingualtext  => monolingualtext
+                * multilingualtext => multilingualtext
+                * quantity         => quantity
+                * string           => string
+                * time             => time
+                * url              => string
+                * wikibase-item    => wikibase-entityid
+                */
+
                $types = array(
-                       'commonsMedia' => array( $this, 'buildMediaType' ),
+                       'commonsMedia'     => array( $this, 'buildMediaType' ),
                        'globe-coordinate' => array( $this, 
'buildCoordinateType' ),
-                       'quantity'=> array( $this, 'buildQuantityType' ),
-                       'string' => array( $this, 'buildStringType' ),
-                       'time' => array( $this, 'buildTimeType' ),
-                       'url' => array( $this, 'buildUrlType' ),
-                       'wikibase-item' => array( $this, 'buildItemType' ),
+                       'quantity'         => array( $this, 'buildQuantityType' 
),
+                       'string'           => array( $this, 'buildStringType' ),
+                       'time'             => array( $this, 'buildTimeType' ),
+                       'url'              => array( $this, 'buildUrlType' ),
+                       'wikibase-item'    => array( $this, 'buildItemType' ),
                );
 
                $experimental = array(

-- 
To view, visit https://gerrit.wikimedia.org/r/134579
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8caed8af113b3c6a748548f974ebd7cee2edd951
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Adrian Lang <adrian.l...@wikimedia.de>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: WikidataJenkins <wikidata-servi...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to