Anomie has uploaded a new change for review.
https://gerrit.wikimedia.org/r/135574
Change subject: Revert more visibility changes in HistoryBlob.php
......................................................................
Revert more visibility changes in HistoryBlob.php
This follows-up bebcf2c58381, which only fixed DiffHistoryBlob.
MediaWiki will fail to load some revisions if the following properties
do not unserialize correctly:
* HistoryBlobStub::$mOldId
* HistoryBlobStub::$mHash
* HistoryBlobCurStub::$mCurId
Visibility of HistoryBlobStub::$mRef is also restored; though the
property's value does not appear to be used after unserialization,
the property is nevertheless a serialized property.
Bug: 65665
Change-Id: I2724d15f9206d66d615d020117e60bb772048c19
(cherry picked from commit 6ca760a5bada5b60fc3fbf64c2890951097d3db2)
---
M includes/HistoryBlob.php
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/74/135574/1
diff --git a/includes/HistoryBlob.php b/includes/HistoryBlob.php
index 06e5ecc..d0cae36 100644
--- a/includes/HistoryBlob.php
+++ b/includes/HistoryBlob.php
@@ -197,13 +197,13 @@
protected static $blobCache = array();
/** @var int */
- protected $mOldId;
+ public $mOldId;
/** @var string */
- protected $mHash;
+ public $mHash;
/** @var */
- protected $mRef;
+ public $mRef;
/**
* @param string $hash The content hash of the text
@@ -313,7 +313,7 @@
*/
class HistoryBlobCurStub {
/** @var int */
- private $mCurId;
+ public $mCurId;
/**
* @param int $curid The cur_id pointed to
--
To view, visit https://gerrit.wikimedia.org/r/135574
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2724d15f9206d66d615d020117e60bb772048c19
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.24wmf6
Gerrit-Owner: Anomie <[email protected]>
Gerrit-Reviewer: PleaseStand <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
