Brion VIBBER has submitted this change and it was merged.
Change subject: Fix for edit pencil not working if user not logged in.
......................................................................
Fix for edit pencil not working if user not logged in.
Change-Id: I8dae0e3212905e21134787ef6fad094cf0d8c764
---
M wikipedia/EventLogging/EditFunnel.m
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Brion VIBBER: Verified; Looks good to me, approved
diff --git a/wikipedia/EventLogging/EditFunnel.m
b/wikipedia/EventLogging/EditFunnel.m
index c13125e..bdf428b 100644
--- a/wikipedia/EventLogging/EditFunnel.m
+++ b/wikipedia/EventLogging/EditFunnel.m
@@ -26,7 +26,8 @@
{
NSMutableDictionary *dict = [eventData mutableCopy];
dict[@"editSessionToken"] = self.editSessionToken;
- dict[@"userName"] = [SessionSingleton
sharedInstance].keychainCredentials.userName;
+ NSString *userName = [SessionSingleton
sharedInstance].keychainCredentials.userName;
+ dict[@"userName"] = userName ? userName : @"";
//dict[@"pageNS"] = @0; // @todo allow other types or ...? // Android
doesn't send this?
return [NSDictionary dictionaryWithDictionary: dict];
}
--
To view, visit https://gerrit.wikimedia.org/r/139024
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8dae0e3212905e21134787ef6fad094cf0d8c764
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mhurd <mh...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
