Tim Starling has submitted this change and it was merged.
Change subject: (bug 34876) Make jquery.makeCollapsible less slow.
......................................................................
(bug 34876) Make jquery.makeCollapsible less slow.
Several optimisations:
* Re-using the same $collapsible jQuery object instead of
re-creation of $(this).
* Use .data instead of dom manipulation (className property).
* Use $.nodeName( HTMLElement, tag ) to check something is <a>,
instead of using creating a jQuery object and calling
"is.('a')", which goes through a lot of selector stuff.
- Fix bug where it says it does instantHide but actually still
triggers the event that causes initial animations.
Thanks to Lupo for most of these ideas, based on this patch:
* https://bugzilla.wikimedia.org/attachment.cgi?id=10200
Verified that these test cases all still work:
https://test.wikipedia.org/wiki/User:Krinkle/CollapsingTestpageMw
(copy wikitext to localhost)
Change-Id: Idb9ca00c03ec7d70903ed7fd79e427efa270ace4
---
M RELEASE-NOTES-1.21
M resources/jquery/jquery.makeCollapsible.js
2 files changed, 125 insertions(+), 85 deletions(-)
Approvals:
Tim Starling: Verified; Looks good to me, approved
--
To view, visit https://gerrit.wikimedia.org/r/21873
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb9ca00c03ec7d70903ed7fd79e427efa270ace4
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Matmarex <[email protected]>
Gerrit-Reviewer: Tim Starling <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
