Withoutaname has uploaded a new change for review. https://gerrit.wikimedia.org/r/139788
Change subject: Removed deprecated WebRequest::escapeAppendQuery() ...................................................................... Removed deprecated WebRequest::escapeAppendQuery() This function was deprecated in 1.20 and slated for removal in 1.22; there were supposed to be warnings given in 1.21 but there does not seem to be any use of this function otherwise in core. Change-Id: If70a4e2c1509bf3527d5f8960c14115ce4ab713e --- M RELEASE-NOTES-1.24 M includes/WebRequest.php 2 files changed, 1 insertion(+), 11 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/88/139788/1 diff --git a/RELEASE-NOTES-1.24 b/RELEASE-NOTES-1.24 index 0779f6b..6a48bc3 100644 --- a/RELEASE-NOTES-1.24 +++ b/RELEASE-NOTES-1.24 @@ -154,6 +154,7 @@ * The skin autodiscovery mechanism has been deprecated and will be removed in MediaWiki 1.25. See https://www.mediawiki.org/wiki/Manual:Skin_autodiscovery for migration guide for creators and users of custom skins that relied on it. +* Removed WebRequest::escapeAppendQuery(). (deprecated since 1.20) ==== Renamed classes ==== * CLDRPluralRuleConverter_Expression to CLDRPluralRuleConverterExpression diff --git a/includes/WebRequest.php b/includes/WebRequest.php index a703b64..ce9fecd 100644 --- a/includes/WebRequest.php +++ b/includes/WebRequest.php @@ -755,17 +755,6 @@ } /** - * HTML-safe version of appendQuery(). - * @deprecated: Deprecated in 1.20, warnings in 1.21, remove in 1.22. - * - * @param string $query Query string fragment; do not include initial '?' - * @return string - */ - public function escapeAppendQuery( $query ) { - return htmlspecialchars( $this->appendQuery( $query ) ); - } - - /** * @param string $key * @param string $value * @param bool $onlyquery -- To view, visit https://gerrit.wikimedia.org/r/139788 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If70a4e2c1509bf3527d5f8960c14115ce4ab713e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Withoutaname <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
