Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/139795
Change subject: Use <a> instead of <a href="#"> for JavaScript click events
......................................................................
Use <a> instead of <a href="#"> for JavaScript click events
* No status line with URL and "#".
* No new tab on middle click.
a { cursor: pointer; } ensures to have a pointer as mouse cursor on hover.
Bug: 42241
Change-Id: I5903901752ffb52e778f3582c7da0f820dc305c8
---
M resources/src/mediawiki.action/mediawiki.action.view.postEdit.js
M resources/src/mediawiki/mediawiki.toc.js
M skins/common/commonElements.css
M skins/vector/Vector.php
4 files changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/95/139795/1
diff --git a/resources/src/mediawiki.action/mediawiki.action.view.postEdit.js
b/resources/src/mediawiki.action/mediawiki.action.view.postEdit.js
index 4d2c47a..f8a291f 100644
--- a/resources/src/mediawiki.action/mediawiki.action.view.postEdit.js
+++ b/resources/src/mediawiki.action/mediawiki.action.view.postEdit.js
@@ -34,7 +34,7 @@
'<div class="postedit-container">' +
'<div class="postedit">' +
'<div class="postedit-icon
postedit-icon-checkmark postedit-content"></div>' +
- '<a href="#"
class="postedit-close">×</a>' +
+ '<a class="postedit-close">×</a>'
+
'</div>' +
'</div>'
);
diff --git a/resources/src/mediawiki/mediawiki.toc.js
b/resources/src/mediawiki/mediawiki.toc.js
index e8dd473..0d15b10 100644
--- a/resources/src/mediawiki/mediawiki.toc.js
+++ b/resources/src/mediawiki/mediawiki.toc.js
@@ -35,7 +35,7 @@
if ( $toc.length && $tocTitle.length && $tocList.length &&
!$tocToggleLink.length ) {
hideToc = $.cookie( 'mw_hidetoc' ) === '1';
- $tocToggleLink = $( '<a href="#" class="internal"
id="togglelink"></a>' )
+ $tocToggleLink = $( '<a class="internal"
id="togglelink"></a>' )
.text( hideToc ? mw.msg( 'showtoc' ) : mw.msg(
'hidetoc' ) )
.click( function ( e ) {
e.preventDefault();
diff --git a/skins/common/commonElements.css b/skins/common/commonElements.css
index 7b2cc40..a9ac12e 100644
--- a/skins/common/commonElements.css
+++ b/skins/common/commonElements.css
@@ -11,6 +11,7 @@
text-decoration: none;
color: #0645ad;
background: none;
+ cursor: pointer; /* Always cursor:pointer even without href */
}
a:visited {
diff --git a/skins/vector/Vector.php b/skins/vector/Vector.php
index 650a52b..00445f9 100644
--- a/skins/vector/Vector.php
+++ b/skins/vector/Vector.php
@@ -493,7 +493,7 @@
?>
</h3>
- <h3
id="p-variants-label"><span><?php $this->msg( 'variants' ) ?></span><a
href="#"></a></h3>
+ <h3
id="p-variants-label"><span><?php $this->msg( 'variants' ) ?></span><a></a></h3>
<div class="menu">
<ul>
@@ -563,7 +563,7 @@
echo ' emptyPortlet';
}
?>" aria-labelledby="p-cactions-label">
- <h3
id="p-cactions-label"><span><?php $this->msg( 'vector-more-actions' )
?></span><a href="#"></a></h3>
+ <h3
id="p-cactions-label"><span><?php $this->msg( 'vector-more-actions' )
?></span><a></a></h3>
<div class="menu">
<ul<?php $this->html(
'userlangattributes' ) ?>>
--
To view, visit https://gerrit.wikimedia.org/r/139795
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5903901752ffb52e778f3582c7da0f820dc305c8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
