Jeroen De Dauw has submitted this change and it was merged. Change subject: Removed transaction logic from ChangeNotifier. ......................................................................
Removed transaction logic from ChangeNotifier. ChangeNotifier used a database transaction to wrapp changes. This caused trouble because it was nested in an already open transaction, which mediawiki doesn't like. I removed the transaction from ChangeNotifier: There is no need for consistency between changes saved to the database. ChangeNotifier contained some code for non-database transactions (or rather, buffer-and-flush logic). This was unused and confusingly named, so I removed it for now. Change-Id: I014274289bb8bab34e25d8c3983816ce87296d2c --- M lib/includes/ChangeNotifier.php 1 file changed, 3 insertions(+), 74 deletions(-) Approvals: Jeroen De Dauw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27278 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I014274289bb8bab34e25d8c3983816ce87296d2c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Aude <[email protected]> Gerrit-Reviewer: Jeroen De Dauw <[email protected]> Gerrit-Reviewer: John Erling Blad <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
