Siebrand has submitted this change and it was merged. Change subject: (bug 31809) Fix drag-and-drop and improve error handling ......................................................................
(bug 31809) Fix drag-and-drop and improve error handling * Fix regression from r89877 which fixed bug 29320 but broke the dragging to new location when merging threads (bug 31809). * Use proper date manipulation to avoid invalid timestamps such as 20120101000000 - 1 = 20120100999999 (instead of 20111231235959) * Followup to r60073: replace "error.description" by "error.info", to avoid incomplete error messages such as "Error: invalid-sortkey: undefined" or "Error: no-valid-subject: undefined". * Remove spinner in case of error. * Add/format some comments * Trim the subject if splitting a thread Change-Id: I4dd10d760402ef6f4cc18a6cccf98f95d415f564 --- M lqt.js 1 file changed, 56 insertions(+), 43 deletions(-) Approvals: Helder.wiki: Looks good to me, but someone else must approve Siebrand: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/17777 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4dd10d760402ef6f4cc18a6cccf98f95d415f564 Gerrit-PatchSet: 7 Gerrit-Project: mediawiki/extensions/LiquidThreads Gerrit-Branch: master Gerrit-Owner: Helder.wiki <[email protected]> Gerrit-Reviewer: Helder.wiki <[email protected]> Gerrit-Reviewer: MarkTraceur <[email protected]> Gerrit-Reviewer: Nikerabbit <[email protected]> Gerrit-Reviewer: Raylton P. Sousa <[email protected]> Gerrit-Reviewer: Siebrand <[email protected]> Gerrit-Reviewer: Werdna <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
