Matanya has uploaded a new change for review.
https://gerrit.wikimedia.org/r/140655
Change subject: kafka: lint
......................................................................
kafka: lint
Change-Id: Id2ac482eedbef947859ff7ac862b6c6a90f2250a
---
M manifests/role/analytics/kafka.pp
1 file changed, 14 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/55/140655/1
diff --git a/manifests/role/analytics/kafka.pp
b/manifests/role/analytics/kafka.pp
index c26927c..51c13e7 100644
--- a/manifests/role/analytics/kafka.pp
+++ b/manifests/role/analytics/kafka.pp
@@ -76,7 +76,19 @@
'/var/spool/kafka/l/data',
]
# Ganglia diskstat plugin would like to know what disks to monitor
- $log_disks = ['sda', 'sdb', 'sdc', 'sdd', 'sde', 'sdf', 'sdg', 'sdh',
'sdi', 'sdj', 'sdk', 'sdl']
+ $log_disks = ['sda',
+ 'sdb',
+ 'sdc',
+ 'sdd',
+ 'sde',
+ 'sdf',
+ 'sdg',
+ 'sdh',
+ 'sdi',
+ 'sdj',
+ 'sdk',
+ 'sdl',
+ ]
# TODO: use variables from new ganglia module once it is finished.
$ganglia_host = '239.192.1.45'
@@ -207,7 +219,7 @@
# monitor disk statistics
ganglia::plugin::python { 'diskstat':
# oof, this did not do what I thought it would:
- # + value = 'sdcsddsdesdfsdgsdhsdisdjsdksdl'
+ # + value = 'sdcsddsdesdfsdgsdhsdisdjsdksdl'
# TODO: FIX THIS!
# opts => { 'devices' => $log_disks },
}
--
To view, visit https://gerrit.wikimedia.org/r/140655
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2ac482eedbef947859ff7ac862b6c6a90f2250a
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Matanya <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
