Krinkle has submitted this change and it was merged. Change subject: inheritClass: Implement inherited 'static' property for classes. ......................................................................
inheritClass: Implement inherited 'static' property for classes. Previously tests for inheritClass (and other object management utilities) were absent (as they were copied from upstream K-js). I've copied the upstream test suite for this method here and extended it with tests for this new feature. Had to add es5:true to .jshintrc due to a bug in JSHint. Repeated the setting in ve.inheritClass for future reference. Source: https://github.com/Krinkle/K-js/blob/master/test/K.test.js Change-Id: I63ac620d6ce7832ebfee454ddf7b7c90f6eb6121 --- M .jshintrc M modules/ve/test/ve.test.js M modules/ve/ve.js 3 files changed, 146 insertions(+), 6 deletions(-) Approvals: Krinkle: Verified; Looks good to me, approved Trevor Parscal: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/26562 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63ac620d6ce7832ebfee454ddf7b7c90f6eb6121 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Trevor Parscal <[email protected]> Gerrit-Reviewer: Catrope <[email protected]> Gerrit-Reviewer: Krinkle <[email protected]> Gerrit-Reviewer: Trevor Parscal <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
