John Erling Blad has submitted this change and it was merged. Change subject: Fixed failing QUnit tests after Id0cb4088 got merged early ......................................................................
Fixed failing QUnit tests after Id0cb4088 got merged early The main problem was that if wb.ui.Toolbar.Label.stateChangeable is false, some of the state handling didn't work logically anymore. This has been fixed now. Another bug which was detected while fixing this is that empty toolbars always returned disabled as state. This has been changed to return enabled (which isn't much better, either the state should be remembered or we should re-thing the state system). Change-Id: If6545d9b24a415c1d3da1cb72ba1e8dda568dff7 --- M repo/resources/wikibase.ui.PropertyEditTool.js M repo/resources/wikibase.ui.Toolbar.js M repo/tests/qunit/wikibase.ui.PropertyEditTool.tests.js M repo/tests/qunit/wikibase.ui.Toolbar.tests.js 4 files changed, 48 insertions(+), 14 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27311 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6545d9b24a415c1d3da1cb72ba1e8dda568dff7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner <[email protected]> Gerrit-Reviewer: John Erling Blad <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
