Hoo man has uploaded a new change for review.
https://gerrit.wikimedia.org/r/141239
Change subject: Don't set badges to an empty array in SpecialSetSiteLink
......................................................................
Don't set badges to an empty array in SpecialSetSiteLink
Bug: 62546
Change-Id: Idf9ced23e8cb1b3b6652ff4f9f24b042d6b41116
---
M repo/includes/specials/SpecialSetSiteLink.php
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/39/141239/1
diff --git a/repo/includes/specials/SpecialSetSiteLink.php
b/repo/includes/specials/SpecialSetSiteLink.php
index 40417b3..f888374 100644
--- a/repo/includes/specials/SpecialSetSiteLink.php
+++ b/repo/includes/specials/SpecialSetSiteLink.php
@@ -454,10 +454,16 @@
}
}
+ $hasBadges =
$item->getSiteLinkList()->hasLinkWithSiteId($siteId) &&
+ $item->getSiteLinkList()->getBySiteId( $siteId
)->getBadges();
+
if ( $badges !== null ) {
$badges = $this->parseBadges( $badges, $status );
- } else {
+ } elseif( $hasBadges ) {
+ // If badges are already present and the field is
empty, remove them
$badges = array();
+ } else {
+ $badges = null;
}
if ( !$status->isGood() ) {
--
To view, visit https://gerrit.wikimedia.org/r/141239
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf9ced23e8cb1b3b6652ff4f9f24b042d6b41116
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
