jenkins-bot has submitted this change and it was merged.
Change subject: Remove unused BC code for SpecialPageTranslationMovePage
......................................................................
Remove unused BC code for SpecialPageTranslationMovePage
Not needed for any of the supported core versions and it was
spewing deprecation notices.
Change-Id: I6379f9ac7798eb6a3be92c198adee4c3eee81837
---
M tag/PageTranslationHooks.php
M tag/SpecialPageTranslationMovePage.php
2 files changed, 4 insertions(+), 28 deletions(-)
Approvals:
MaxSem: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tag/PageTranslationHooks.php b/tag/PageTranslationHooks.php
index d7dfc25..f23382a 100644
--- a/tag/PageTranslationHooks.php
+++ b/tag/PageTranslationHooks.php
@@ -758,8 +758,7 @@
/// Hook: SpecialPage_initList
public static function replaceMovePage( &$list ) {
- $old = is_array( $list['Movepage'] );
- $list['Movepage'] = array( 'SpecialPageTranslationMovePage',
$old );
+ $list['Movepage'] = 'SpecialPageTranslationMovePage';
return true;
}
diff --git a/tag/SpecialPageTranslationMovePage.php
b/tag/SpecialPageTranslationMovePage.php
index ec2001f..5aa3274 100644
--- a/tag/SpecialPageTranslationMovePage.php
+++ b/tag/SpecialPageTranslationMovePage.php
@@ -59,9 +59,8 @@
*/
protected $sectionPages = null;
- public function __construct( $old ) {
+ public function __construct() {
parent::__construct( 'Movepage' );
- $this->old = $old;
}
public function isListed() {
@@ -133,11 +132,8 @@
}
} else {
// Delegate... don't want to reimplement this
- if ( $this->old ) {
- $this->doOldNormalMovePage();
- } else {
- $this->doNormalMovePage( $par );
- }
+ $sp = new MovePageForm();
+ $sp->execute( $par );
}
}
@@ -169,25 +165,6 @@
// Let the caller know it's safe to continue
return true;
- }
-
- protected function doNormalMovePage( $par ) {
- $sp = new MovePageForm();
- $sp->execute( $par );
- }
-
- protected function doOldNormalMovePage() {
- $form = new MovePageForm( $this->oldTitle, $this->newTitle );
- $request = $this->getRequest();
-
- if ( 'submit' == $request->getVal( 'action' ) &&
- $this->checkToken() &&
- $request->wasPosted()
- ) {
- $form->doSubmit();
- } else {
- $form->showForm( '' );
- }
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/141124
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6379f9ac7798eb6a3be92c198adee4c3eee81837
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
