Jeroen De Dauw has submitted this change and it was merged. Change subject: (Bug 40381) Use prefixed id ......................................................................
(Bug 40381) Use prefixed id Updated the code to both handle prefixed and non-prefixed ids. The prefixed ids will be used for keys, but will not be used in the "id" field as this is numeric. Checking for a prefixed id is done in a try-catch, which is somewhat awkward, but fixing this (that is creating a better test) should be done in EntityFactory, and also in another changeset. Patchset 2: Removed unused boolean Change-Id: Ib02c655485087c4322233a6e4f8f089bcf3c9874 --- M repo/includes/api/ApiGetEntities.php M repo/includes/api/ApiModifyEntity.php M repo/includes/content/EntityContentFactory.php M repo/tests/phpunit/includes/api/ApiGetEntitiesTest.php M repo/tests/phpunit/includes/api/ApiSetItemTest.php 5 files changed, 90 insertions(+), 8 deletions(-) Approvals: Jeroen De Dauw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27406 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib02c655485087c4322233a6e4f8f089bcf3c9874 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: John Erling Blad <[email protected]> Gerrit-Reviewer: Jeroen De Dauw <[email protected]> Gerrit-Reviewer: John Erling Blad <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
