BearND has uploaded a new change for review.
https://gerrit.wikimedia.org/r/142196
Change subject: NPE: println needs a message
......................................................................
NPE: println needs a message
Bug: 67112
Change-Id: I7dad32ccc856123d31108fa500fd8b6230108ae7
---
M wikipedia/src/main/java/org/wikipedia/RemoteConfigRefreshTask.java
M wikipedia/src/main/java/org/wikipedia/bridge/StyleFetcherTask.java
M wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java
M wikipedia/src/main/java/org/wikipedia/editing/EditSectionActivity.java
M wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
5 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/96/142196/1
diff --git a/wikipedia/src/main/java/org/wikipedia/RemoteConfigRefreshTask.java
b/wikipedia/src/main/java/org/wikipedia/RemoteConfigRefreshTask.java
index a56724b..fef6538 100644
--- a/wikipedia/src/main/java/org/wikipedia/RemoteConfigRefreshTask.java
+++ b/wikipedia/src/main/java/org/wikipedia/RemoteConfigRefreshTask.java
@@ -40,7 +40,7 @@
@Override
public void onCatch(Throwable caught) {
// Don't do anything, but do write out a log statement. We
don't particularly care.
- Log.d("Wikipedia", caught.toString());
+ Log.d("Wikipedia", "Caught " + caught.toString());
}
}.execute();
}
diff --git a/wikipedia/src/main/java/org/wikipedia/bridge/StyleFetcherTask.java
b/wikipedia/src/main/java/org/wikipedia/bridge/StyleFetcherTask.java
index f13c314..ce6ce09 100644
--- a/wikipedia/src/main/java/org/wikipedia/bridge/StyleFetcherTask.java
+++ b/wikipedia/src/main/java/org/wikipedia/bridge/StyleFetcherTask.java
@@ -82,11 +82,11 @@
throw new RuntimeException(e);
} catch (IOException e) {
// FIXME: better error feedback?
- Log.d("StyleFetcherTask", e.getMessage());
+ Log.d("StyleFetcherTask", "IOException " + e.getMessage());
e.printStackTrace();
} catch (HttpRequest.HttpRequestException e) {
// FIXME: better error feedback?
- Log.d("StyleFetcherTask", e.getMessage());
+ Log.d("StyleFetcherTask", "HttpRequestException: " +
e.getMessage());
e.printStackTrace();
}
}
diff --git
a/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java
b/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java
index 2b0f913..5950ac6 100644
--- a/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java
@@ -214,7 +214,7 @@
|| caught instanceof
HttpRequest.HttpRequestException)) {
throw new RuntimeException(caught);
}
- Log.d("Wikipedia", caught.toString());
+ Log.d("Wikipedia", "Caught " + caught.toString());
final AlertDialog retryDialog = new
AlertDialog.Builder(getActivity())
.setMessage(R.string.error_network_error)
.setPositiveButton(R.string.dialog_message_edit_failed_retry, new
DialogInterface.OnClickListener() {
diff --git
a/wikipedia/src/main/java/org/wikipedia/editing/EditSectionActivity.java
b/wikipedia/src/main/java/org/wikipedia/editing/EditSectionActivity.java
index c746caa..632986f 100644
--- a/wikipedia/src/main/java/org/wikipedia/editing/EditSectionActivity.java
+++ b/wikipedia/src/main/java/org/wikipedia/editing/EditSectionActivity.java
@@ -340,7 +340,7 @@
if (!(caught instanceof
HttpRequest.HttpRequestException)) {
throw new RuntimeException(caught);
}
- Log.d("Wikipedia", caught.toString());
+ Log.d("Wikipedia", "Caught " + caught.toString());
final AlertDialog retryDialog = new
AlertDialog.Builder(EditSectionActivity.this)
.setMessage(R.string.dialog_message_edit_failed)
.setPositiveButton(R.string.dialog_message_edit_failed_retry, new
DialogInterface.OnClickListener() {
diff --git a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
index 7ac2aeb..86d621a 100644
--- a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
@@ -438,7 +438,7 @@
@Override
public void onCatch(Throwable caught) {
- Log.d("HistorySaveTask", caught.getMessage());
+ Log.d("HistorySaveTask", "Caught " + caught.getMessage());
}
}
--
To view, visit https://gerrit.wikimedia.org/r/142196
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7dad32ccc856123d31108fa500fd8b6230108ae7
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: BearND <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
