EBernhardson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/142200

Change subject: Consistently use TemplateHelper::html
......................................................................

Consistently use TemplateHelper::html

Use the same pattern for bypassing autoescape in all
helper methods to increase searchability.

Change-Id: I6644d1d1a20a95b494407a85925885f808284e41
---
M includes/TemplateHelper.php
1 file changed, 8 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/00/142200/1

diff --git a/includes/TemplateHelper.php b/includes/TemplateHelper.php
index 9a6fcd3..105694f 100644
--- a/includes/TemplateHelper.php
+++ b/includes/TemplateHelper.php
@@ -579,7 +579,7 @@
        static public function l10nParse( $str /*, $args... */ ) {
                $args = func_get_args();
                array_shift( $args );
-               return array( wfMessage( $str, $args )->parse(), 'raw' );
+               return self::html( wfMessage( $str, $args )->parse() );
        }
 
        /**
@@ -604,16 +604,13 @@
                }
                $differenceEngine->showDiffStyle();
 
-               return array(
-                       $differenceEngine->addHeader(
-                               $diffContent,
-                               self::generateDiffViewTitle( $oldTimestamp, 
$oldAuthor, $oldLink ),
-                               self::generateDiffViewTitle( $newTimestamp, 
$newAuthor, $newLink ),
-                               $multi,
-                               $notice
-                       ),
-                       'raw'
-               );
+               return self::html( $differenceEngine->addHeader(
+                       $diffContent,
+                       self::generateDiffViewTitle( $oldTimestamp, $oldAuthor, 
$oldLink ),
+                       self::generateDiffViewTitle( $newTimestamp, $newAuthor, 
$newLink ),
+                       $multi,
+                       $notice
+               ) );
        }
 
        /**

-- 
To view, visit https://gerrit.wikimedia.org/r/142200
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6644d1d1a20a95b494407a85925885f808284e41
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: frontend-rewrite
Gerrit-Owner: EBernhardson <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to