Henning Snater has uploaded a new change for review.
https://gerrit.wikimedia.org/r/142217
Change subject: Apply widgetEventPrefix to snak type selector event listener
......................................................................
Apply widgetEventPrefix to snak type selector event listener
(Selenium tests will be added in a subsequent change set.)
Change-Id: I99f4d56145335ab0aac75abc805aca87b1f50c86
---
M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/17/142217/1
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
index df328a3..3da8873 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
@@ -272,7 +272,7 @@
this.draw();
// attach keyboard input events
- this.element.on( 'keydown.' + this.widgetEventPrefix,
function( event ) {
+ this.element.on( 'keydown.' + this.widgetName,
function( event ) {
if ( self.isDisabled() ) {
return;
}
@@ -831,8 +831,10 @@
// ...add the data information nevertheless:
$anchor.data( 'snaktypeselector', selector );
+ var changeEvent = ( selector.widgetEventPrefix + 'afterchange'
).toLowerCase();
+
// bind user interaction on selector to snakview's state:
- $anchor.on( 'afterchange', function( event ) {
+ $anchor.on( changeEvent + '.' + this.widgetName, function(
event ) {
self.snakType( selector.snakType() );
if( self._variation ) {
self._variation.focus();
--
To view, visit https://gerrit.wikimedia.org/r/142217
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I99f4d56145335ab0aac75abc805aca87b1f50c86
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
