Bsitu has submitted this change and it was merged. Change subject: Fix PHP notice when running phpunit tests ......................................................................
Fix PHP notice when running phpunit tests When running phpunit, this method is being called, which calls ArticleMetadata::getValidTags(), which produces a query to pagetriage_tags. Unittests will execute this query: SELECT ptrt_tag_id,ptrt_tag_name FROM `unittest_pagetriage_tags` (tests/phpunit/MediaWikiTestCase.php defined that table prefix) The odds of that table _not_ containing the correct data are quite reasonable (I'm running into the problem), so $tags will be empty, causing $tags['user_name'] to throw a notice upon running tests. Change-Id: If991f1a54723575acfac627a5759e386ccb67c58 --- M includes/PageTriageUtil.php 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Bsitu: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27403 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If991f1a54723575acfac627a5759e386ccb67c58 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/PageTriage Gerrit-Branch: master Gerrit-Owner: Matthias Mullie <[email protected]> Gerrit-Reviewer: Bsitu <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
