Dbrant has submitted this change and it was merged. Change subject: Make background lighter in site selection list item ......................................................................
Make background lighter in site selection list item On GingerBread the text was black on black. Also there was no padding on the sides. Change-Id: Iefa1c8fbf9514e399ea727a3ca1ce38985a5ccfb --- M wikipedia/res/layout/simple_list_item_activated_2.xml 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Dbrant: Looks good to me, approved diff --git a/wikipedia/res/layout/simple_list_item_activated_2.xml b/wikipedia/res/layout/simple_list_item_activated_2.xml index 6bea482..a32aab0 100644 --- a/wikipedia/res/layout/simple_list_item_activated_2.xml +++ b/wikipedia/res/layout/simple_list_item_activated_2.xml @@ -17,9 +17,11 @@ <TwoLineListItem xmlns:android="http://schemas.android.com/apk/res/android"; android:paddingTop="2dip" android:paddingBottom="2dip" + android:paddingLeft="16dip" + android:paddingRight="16dip" android:layout_width="match_parent" android:layout_height="wrap_content" - android:background="@drawable/activated_background_holo_light" + android:background="@android:color/background_light" android:minHeight="?android:attr/listPreferredItemHeight" android:mode="twoLine" > -- To view, visit https://gerrit.wikimedia.org/r/141645 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefa1c8fbf9514e399ea727a3ca1ce38985a5ccfb Gerrit-PatchSet: 2 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: BearND <bsitzm...@wikimedia.org> Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
