Scottlee has uploaded a new change for review. https://gerrit.wikimedia.org/r/142543
Change subject: Fixed puppet-lint issues on manifests/role/analytics/hadoop.pp. ...................................................................... Fixed puppet-lint issues on manifests/role/analytics/hadoop.pp. Change-Id: I5c4c5994785429f181cd866a9bc358d582c41a5d --- M manifests/role/analytics/hadoop.pp 1 file changed, 20 insertions(+), 21 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/43/142543/1 diff --git a/manifests/role/analytics/hadoop.pp b/manifests/role/analytics/hadoop.pp index f5d6b15..ddfdc96 100644 --- a/manifests/role/analytics/hadoop.pp +++ b/manifests/role/analytics/hadoop.pp @@ -71,10 +71,10 @@ } # Alert if this NameNode is not active monitor_ganglia { 'hadoop-hdfs-namenode-primary-is-active': - description => 'Hadoop NameNode Primary Is Active', - metric => 'Hadoop.NameNode.FSNamesystem.tag_HAState', - warning => '\!active', - critical => '\!active', + description => 'Hadoop NameNode Primary Is Active', + metric => 'Hadoop.NameNode.FSNamesystem.tag_HAState', + warning => '\!active', + critical => '\!active', require => Class['::cdh4::hadoop::master'], } @@ -194,16 +194,16 @@ $hadoop_journal_directory = '/var/lib/hadoop/journal' $datanode_mounts = [ - "$hadoop_data_directory/c", - "$hadoop_data_directory/d", - "$hadoop_data_directory/e", - "$hadoop_data_directory/f", - "$hadoop_data_directory/g", - "$hadoop_data_directory/h", - "$hadoop_data_directory/i", - "$hadoop_data_directory/j", - "$hadoop_data_directory/k", - "$hadoop_data_directory/l" + "${hadoop_data_directory}/c", + "${hadoop_data_directory}/d", + "${hadoop_data_directory}/e", + "${hadoop_data_directory}/f", + "${hadoop_data_directory}/g", + "${hadoop_data_directory}/h", + "${hadoop_data_directory}/i", + "${hadoop_data_directory}/j", + "${hadoop_data_directory}/k", + "${hadoop_data_directory}/l" ] class { 'cdh4::hadoop': @@ -237,11 +237,11 @@ net_topology_script_template => 'hadoop/net-topology.py.erb', } - file { "$::cdh4::hadoop::config_directory/fair-scheduler.xml": + file { "${::cdh4::hadoop::config_directory}/fair-scheduler.xml": content => template('hadoop/fair-scheduler.xml.erb'), require => Class['cdh4::hadoop'], } - file { "$::cdh4::hadoop::config_directory/fair-scheduler-allocation.xml": + file { "${::cdh4::hadoop::config_directory}/fair-scheduler-allocation.xml": content => template('hadoop/fair-scheduler-allocation.xml.erb'), require => Class['cdh4::hadoop'], } @@ -292,8 +292,8 @@ $hadoop_data_directory = '/var/lib/hadoop/data' $datanode_mounts = [ - "$hadoop_data_directory/a", - "$hadoop_data_directory/b", + "${hadoop_data_directory}/a", + "${hadoop_data_directory}/b", ] $hadoop_journal_directory = '/var/lib/hadoop/journal' @@ -326,14 +326,13 @@ yarn_resourcemanager_scheduler_class => 'org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler', } - file { "$::cdh4::hadoop::config_directory/fair-scheduler.xml": + file { "${::cdh4::hadoop::config_directory}/fair-scheduler.xml": content => template('hadoop/fair-scheduler.xml.erb'), require => Class['cdh4::hadoop'], } - file { "$::cdh4::hadoop::config_directory/fair-scheduler-allocation.xml": + file { "${::cdh4::hadoop::config_directory}/fair-scheduler-allocation.xml": content => template('hadoop/fair-scheduler-allocation.xml.erb'), require => Class['cdh4::hadoop'], } } - -- To view, visit https://gerrit.wikimedia.org/r/142543 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5c4c5994785429f181cd866a9bc358d582c41a5d Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Scottlee <scott.l...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits