jenkins-bot has submitted this change and it was merged.
Change subject: Apply widgetEventPrefix to rank selector event listener
......................................................................
Apply widgetEventPrefix to rank selector event listener
(bug 66633)
(Selenium tests will be added in a subsequent change set.)
Change-Id: Iff6253769c764319ef4756fa53a5d2cc777da275
---
M lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Aude: Looks good to me, but someone else must approve
WikidataJenkins: Verified
Thiemo Mättig (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
index efbcfdb..96c7437 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
@@ -184,9 +184,9 @@
}, $rankSelector );
var self = this,
- changeEvent = 'afterchange.' + this.widgetName;
+ changeEvent = ( this._rankSelector.widgetEventPrefix +
'afterchange' ).toLowerCase();
- this.$rankSelector.on( changeEvent, function( event ) {
+ this.$rankSelector.on( changeEvent + '.' + this.widgetName,
function( event ) {
if( self.value() ) {
self._trigger( 'change' );
}
--
To view, visit https://gerrit.wikimedia.org/r/142216
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff6253769c764319ef4756fa53a5d2cc777da275
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: WikidataJenkins <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
