Alex Monk has uploaded a new change for review.
https://gerrit.wikimedia.org/r/143055
Change subject: Set tabindex on button <div> instead of <a>
......................................................................
Set tabindex on button <div> instead of <a>
This apparently makes Firefox happy
See also I6cf69c7e
Bug: 65554
Change-Id: I1a11f43a6e2e9f1cbbe243a599caa507c705e13c
---
M src/elements/ButtonedElement.js
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/55/143055/1
diff --git a/src/elements/ButtonedElement.js b/src/elements/ButtonedElement.js
index 00a0f28..d04c0a9 100644
--- a/src/elements/ButtonedElement.js
+++ b/src/elements/ButtonedElement.js
@@ -24,11 +24,12 @@
this.$button.on( 'mousedown', OO.ui.bind( this.onMouseDown, this ) );
// Initialization
- this.$element.addClass( 'oo-ui-buttonedElement' );
+ this.$element
+ .addClass( 'oo-ui-buttonedElement' )
+ .prop( 'tabIndex', config.tabIndex || 0 );
this.$button
.addClass( 'oo-ui-buttonedElement-button' )
- .attr( 'role', 'button' )
- .prop( 'tabIndex', config.tabIndex || 0 );
+ .attr( 'role', 'button' );
if ( config.frameless ) {
this.$element.addClass( 'oo-ui-buttonedElement-frameless' );
} else {
--
To view, visit https://gerrit.wikimedia.org/r/143055
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a11f43a6e2e9f1cbbe243a599caa507c705e13c
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
