Brion VIBBER has submitted this change and it was merged.
Change subject: Fix for logo being too close to screen top on 3.5 inch screens.
......................................................................
Fix for logo being too close to screen top on 3.5 inch screens.
Change-Id: I4a7addfa12bb923227bdce4c70499c983b7bb66f
---
M wikipedia/Base.lproj/Main_iPhone.storyboard
M wikipedia/View Controllers/Onboarding/OnboardingViewController.m
2 files changed, 7 insertions(+), 2 deletions(-)
Approvals:
Brion VIBBER: Verified; Looks good to me, approved
diff --git a/wikipedia/Base.lproj/Main_iPhone.storyboard
b/wikipedia/Base.lproj/Main_iPhone.storyboard
index ad70e03..cfd1212 100644
--- a/wikipedia/Base.lproj/Main_iPhone.storyboard
+++ b/wikipedia/Base.lproj/Main_iPhone.storyboard
@@ -1057,6 +1057,7 @@
<connections>
<outlet property="createAccountButton"
destination="wkl-j8-wLX" id="Q0x-Lf-aBP"/>
<outlet property="loginButton"
destination="heA-3K-nhS" id="90C-kg-bai"/>
+ <outlet property="logoImage" destination="K0v-hf-TOf"
id="IDl-op-jI7"/>
<outlet property="skipButton" destination="P6J-IE-CiO"
id="uVS-3Y-c6m"/>
<outlet property="spaceAboveLogoConstraint"
destination="0B0-Zk-SGf" id="Xaw-AS-lGs"/>
<outlet property="spaceBelowLogoConstraint"
destination="nWX-Cw-MAY" id="RnU-fa-AFO"/>
diff --git a/wikipedia/View Controllers/Onboarding/OnboardingViewController.m
b/wikipedia/View Controllers/Onboarding/OnboardingViewController.m
index c4386d5..abd26d3 100644
--- a/wikipedia/View Controllers/Onboarding/OnboardingViewController.m
+++ b/wikipedia/View Controllers/Onboarding/OnboardingViewController.m
@@ -22,6 +22,8 @@
@property (weak, nonatomic) IBOutlet NSLayoutConstraint
*spaceBelowLogoConstraint;
@property (weak, nonatomic) IBOutlet NSLayoutConstraint
*spaceAboveLogoConstraint;
+@property (weak, nonatomic) IBOutlet UIImageView *logoImage;
+
@end
@implementation OnboardingViewController
@@ -85,10 +87,12 @@
CGFloat aboveMultiplier = 1.0;
CGFloat belowMultiplier = 1.0;
switch ((int)[UIScreen mainScreen].bounds.size.height) {
- case 480:
+ case 480:{
// Make everything fit on 3.5 inch screens.
- aboveMultiplier = 0.2;
+ aboveMultiplier = 1.0;
belowMultiplier = 0.0;
+ self.logoImage.layer.transform = CATransform3DMakeScale(0.85,
0.85, 1.0);
+ }
break;
case 1024:
// Make everything fit on iPad screens.
--
To view, visit https://gerrit.wikimedia.org/r/143066
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a7addfa12bb923227bdce4c70499c983b7bb66f
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mhurd <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
