IAlex has uploaded a new change for review.
https://gerrit.wikimedia.org/r/143085
Change subject: Don't use isset() to check for null
......................................................................
Don't use isset() to check for null
$wgLocalTZoffset is defined in DefaultSettings.php so it is always set.
Change-Id: I86518176b30da4e13f6dbfde8f1c77c8ced58d9f
---
M includes/MWTimestamp.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/85/143085/1
diff --git a/includes/MWTimestamp.php b/includes/MWTimestamp.php
index 447dde3..ad3228d 100644
--- a/includes/MWTimestamp.php
+++ b/includes/MWTimestamp.php
@@ -268,7 +268,7 @@
// first value.
if ( $data[0] == 'System' ) {
// First value is System, so use the system offset.
- if ( isset( $wgLocalTZoffset ) ) {
+ if ( $wgLocalTZoffset !== null ) {
$diff = $wgLocalTZoffset;
}
} elseif ( $data[0] == 'Offset' ) {
--
To view, visit https://gerrit.wikimedia.org/r/143085
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I86518176b30da4e13f6dbfde8f1c77c8ced58d9f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: IAlex <coderev...@emsenhuber.ch>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
