Kaldari has submitted this change and it was merged. Change subject: Fix feedback page issues ......................................................................
Fix feedback page issues - Remove "empty feedback" check on pageload since it's filter-dependent; added new check to add a "There is no feedback for the filter you selected." warning (below the filter controls) upon loading any given filter - Removed "filtervalue" (which was only being used to pass on a feedback id) & the "highlight" filter & replaced it by a way of fetching a specific feedback id that should still abide the selected filters (rather than loading that feedback id regardless of what filter is selected) - Fixed an issue in fetching data where oversighters, for oversight-only actions, were unable to see feedback that was hidden PS2: highlighted posts again ignores other filters Change-Id: I1533cc6c8c130c183babde9bc28e4789406a5dad --- M ArticleFeedbackv5.fetch.php M ArticleFeedbackv5.i18n.php M SpecialArticleFeedbackv5.php M api/ApiViewFeedbackArticleFeedbackv5.php M modules/ext.articleFeedbackv5/ext.articleFeedbackv5.dashboard.css M modules/ext.articleFeedbackv5/ext.articleFeedbackv5.dashboard.js M modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js 7 files changed, 63 insertions(+), 42 deletions(-) Approvals: Kaldari: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27523 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1533cc6c8c130c183babde9bc28e4789406a5dad Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/ArticleFeedbackv5 Gerrit-Branch: master Gerrit-Owner: Matthias Mullie <[email protected]> Gerrit-Reviewer: Bsitu <[email protected]> Gerrit-Reviewer: Kaldari <[email protected]> Gerrit-Reviewer: Matthias Mullie <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
