Catrope has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/143807

Change subject: [WIP] Fix highlights on references in IE
......................................................................

[WIP] Fix highlights on references in IE

Make references display: inline-block; which triggers hasLayout
and fixes IE's measurement of where the <sup> is. Without this,
IE thinks it's at the baseline of the paragraph.

Change-Id: I654b9249d6f1e107d48d55cb6c046e1f13fb1fb0
TODO: only apply this in IE
---
M modules/ve-mw/ce/styles/nodes/ve.ce.MWReferenceNode.css
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/07/143807/1

diff --git a/modules/ve-mw/ce/styles/nodes/ve.ce.MWReferenceNode.css 
b/modules/ve-mw/ce/styles/nodes/ve.ce.MWReferenceNode.css
index 39dbbfb..690e615 100644
--- a/modules/ve-mw/ce/styles/nodes/ve.ce.MWReferenceNode.css
+++ b/modules/ve-mw/ce/styles/nodes/ve.ce.MWReferenceNode.css
@@ -13,3 +13,8 @@
 .mw-ext-cite-error {
        display: none;
 }
+
+/* IE HACK: force hasLayout so the <sup>'s box gets measured correctly */
+.ve-ce-mwReferenceNode {
+       display: inline-block;
+}
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/143807
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I654b9249d6f1e107d48d55cb6c046e1f13fb1fb0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to