Brian Wolff has uploaded a new change for review.
https://gerrit.wikimedia.org/r/143814
Change subject: Do not include file redirects in Special:Wantedfiles
......................................................................
Do not include file redirects in Special:Wantedfiles
If you look at [[Special:WantedFiles]] on commons, its full
of file redirects, making the page kind of useless. This makes
the query much more complex, but at least the page will be useful.
The page will still be useless on non-commons projects due to
foreign files being listed as missing.
Change-Id: I115fdaa3b67bee81ba0a715ebb427bb35cf0f67e
---
M includes/specials/SpecialWantedfiles.php
1 file changed, 27 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/14/143814/1
diff --git a/includes/specials/SpecialWantedfiles.php
b/includes/specials/SpecialWantedfiles.php
index fa68504..fa29729 100644
--- a/includes/specials/SpecialWantedfiles.php
+++ b/includes/specials/SpecialWantedfiles.php
@@ -74,17 +74,39 @@
function getQueryInfo() {
return array(
- 'tables' => array( 'imagelinks', 'image' ),
+ 'tables' => array(
+ 'imagelinks',
+ 'page',
+ 'redirect',
+ 'img1' => 'image',
+ 'img2' => 'image',
+ ),
'fields' => array(
'namespace' => NS_FILE,
'title' => 'il_to',
'value' => 'COUNT(*)'
),
- 'conds' => array( 'img_name IS NULL' ),
+ 'conds' => array(
+ 'img1.img_name' => null,
+ // We also need to exclude file redirects
+ 'img2.img_name' => null,
+ ),
'options' => array( 'GROUP BY' => 'il_to' ),
- 'join_conds' => array( 'image' =>
- array( 'LEFT JOIN',
- array( 'il_to = img_name' )
+ 'join_conds' => array(
+ 'img1' => array( 'LEFT JOIN',
+ 'il_to = img_name'
+ ),
+ 'page' => array( 'LEFT JOIN', array(
+ 'il_to = page_title',
+ 'page_namespace' => NS_FILE,
+ ) ),
+ 'redirect' => array( 'LEFT JOIN', array(
+ 'page_id = rd_from',
+ 'rd_namespace' => NS_FILE,
+ 'rd_interwiki' => ''
+ ) ),
+ 'img2' => array( 'LEFT JOIN',
+ 'rd_title = img2.img_name'
)
)
);
--
To view, visit https://gerrit.wikimedia.org/r/143814
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I115fdaa3b67bee81ba0a715ebb427bb35cf0f67e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Brian Wolff <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
